| Message ID | 20210221210256.68198-1-eliadevito@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile" | expand |
Hi, On 2/21/21 10:02 PM, Elia Devito wrote: > rename "thermal policy" with the more appropriate term "thermal profile" > > Signed-off-by: Elia Devito <eliadevito@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> I will merge this once we are out of the merge-window / once 5.12-rc1 is out. Regards, Hans > --- > drivers/platform/x86/hp-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index e94e59283ecb..6d7b91b8109b 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -85,7 +85,7 @@ enum hp_wmi_commandtype { > HPWMI_FEATURE2_QUERY = 0x0d, > HPWMI_WIRELESS2_QUERY = 0x1b, > HPWMI_POSTCODEERROR_QUERY = 0x2a, > - HPWMI_THERMAL_POLICY_QUERY = 0x4c, > + HPWMI_THERMAL_PROFILE_QUERY = 0x4c, > }; > > enum hp_wmi_command { > @@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device) > return err; > } > > -static int thermal_policy_setup(struct platform_device *device) > +static int thermal_profile_setup(struct platform_device *device) > { > int err, tp; > > - tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY); > + tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY); > if (tp < 0) > return tp; > > /* > - * call thermal policy write command to ensure that the firmware correctly > + * call thermal profile write command to ensure that the firmware correctly > * sets the OEM variables for the DPTF > */ > - err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp, > + err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp, > sizeof(tp), 0); > if (err) > return err; > @@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) > if (hp_wmi_rfkill_setup(device)) > hp_wmi_rfkill2_setup(device); > > - thermal_policy_setup(device); > + thermal_profile_setup(device); > > return 0; > } >
Hi, On 2/21/21 10:02 PM, Elia Devito wrote: > rename "thermal policy" with the more appropriate term "thermal profile" > > Signed-off-by: Elia Devito <eliadevito@gmail.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/hp-wmi.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c > index e94e59283ecb..6d7b91b8109b 100644 > --- a/drivers/platform/x86/hp-wmi.c > +++ b/drivers/platform/x86/hp-wmi.c > @@ -85,7 +85,7 @@ enum hp_wmi_commandtype { > HPWMI_FEATURE2_QUERY = 0x0d, > HPWMI_WIRELESS2_QUERY = 0x1b, > HPWMI_POSTCODEERROR_QUERY = 0x2a, > - HPWMI_THERMAL_POLICY_QUERY = 0x4c, > + HPWMI_THERMAL_PROFILE_QUERY = 0x4c, > }; > > enum hp_wmi_command { > @@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device) > return err; > } > > -static int thermal_policy_setup(struct platform_device *device) > +static int thermal_profile_setup(struct platform_device *device) > { > int err, tp; > > - tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY); > + tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY); > if (tp < 0) > return tp; > > /* > - * call thermal policy write command to ensure that the firmware correctly > + * call thermal profile write command to ensure that the firmware correctly > * sets the OEM variables for the DPTF > */ > - err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp, > + err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp, > sizeof(tp), 0); > if (err) > return err; > @@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) > if (hp_wmi_rfkill_setup(device)) > hp_wmi_rfkill2_setup(device); > > - thermal_policy_setup(device); > + thermal_profile_setup(device); > > return 0; > } >
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index e94e59283ecb..6d7b91b8109b 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -85,7 +85,7 @@ enum hp_wmi_commandtype { HPWMI_FEATURE2_QUERY = 0x0d, HPWMI_WIRELESS2_QUERY = 0x1b, HPWMI_POSTCODEERROR_QUERY = 0x2a, - HPWMI_THERMAL_POLICY_QUERY = 0x4c, + HPWMI_THERMAL_PROFILE_QUERY = 0x4c, }; enum hp_wmi_command { @@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device) return err; } -static int thermal_policy_setup(struct platform_device *device) +static int thermal_profile_setup(struct platform_device *device) { int err, tp; - tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY); + tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY); if (tp < 0) return tp; /* - * call thermal policy write command to ensure that the firmware correctly + * call thermal profile write command to ensure that the firmware correctly * sets the OEM variables for the DPTF */ - err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp, + err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp, sizeof(tp), 0); if (err) return err; @@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device) if (hp_wmi_rfkill_setup(device)) hp_wmi_rfkill2_setup(device); - thermal_policy_setup(device); + thermal_profile_setup(device); return 0; }
rename "thermal policy" with the more appropriate term "thermal profile" Signed-off-by: Elia Devito <eliadevito@gmail.com> --- drivers/platform/x86/hp-wmi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)