| Message ID | 20210211175015.200772-8-angelogioacchino.delregno@somainline.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for IPA v3.1, GSI v1.0, MSM8998 IPA | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: robh+dt@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | fail | Errors and warnings before: 27 this patch: 27 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > MSM8998 support has been added: document the new compatible. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> With the previous patch in place, this becomes almost automatic. But I don't want to claim support for a platform until things actually *work*. I don't just mean we can compile and load (and load firmware), I want to be able to say we can actually carry LTE data over IPA before we advertise the compatible string here. Maybe I'm being picky, but that's my preference. It adds some motivation for getting the user space tools squared away. Thank you again very much for your patches. -Alex > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index b063c6c1077a..9dacd224b606 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -46,6 +46,7 @@ properties: > oneOf: > - items: > - enum: > + - "qcom,msm8998-ipa" > - "qcom,sdm845-ipa" > - "qcom,sc7180-ipa" > >
On Thu, Feb 11, 2021 at 06:50:15PM +0100, AngeloGioacchino Del Regno wrote: > MSM8998 support has been added: document the new compatible. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index b063c6c1077a..9dacd224b606 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -46,6 +46,7 @@ properties: > oneOf: > - items: > - enum: > + - "qcom,msm8998-ipa" Also, don't need quotes on these. > - "qcom,sdm845-ipa" > - "qcom,sc7180-ipa" > > -- > 2.30.0 >
On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > MSM8998 support has been added: document the new compatible. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> The upstream file affected here now has a slightly different format. I will implement this change, credit you for having first proposed it, and will include a link to your original message. -Alex > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index b063c6c1077a..9dacd224b606 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -46,6 +46,7 @@ properties: > oneOf: > - items: > - enum: > + - "qcom,msm8998-ipa" > - "qcom,sdm845-ipa" > - "qcom,sc7180-ipa" > >
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index b063c6c1077a..9dacd224b606 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -46,6 +46,7 @@ properties: oneOf: - items: - enum: + - "qcom,msm8998-ipa" - "qcom,sdm845-ipa" - "qcom,sc7180-ipa"
MSM8998 support has been added: document the new compatible. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + 1 file changed, 1 insertion(+)