| Message ID | 20210312163651.1398207-1-jarod@redhat.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] wireless/nl80211: fix wdev_id may be used uninitialized | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Jarod Wilson <jarod@redhat.com> writes: > Build currently fails with -Werror=maybe-uninitialized set: > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used > uninitialized in this function [-Werror=maybe-uninitialized] Really, build fails? Is -Werror enabled by default now? I hope not.
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo <kvalo@codeaurora.org> wrote: > > Jarod Wilson <jarod@redhat.com> writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used > > uninitialized in this function [-Werror=maybe-uninitialized] > > Really, build fails? Is -Werror enabled by default now? I hope not. Don't think so. But we (Red Hat) build all our kernels with a fair amount of extra error-checking enabled.
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 521d36bb0803..a157783760c7 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -70,7 +70,7 @@ __cfg80211_wdev_from_attrs(struct cfg80211_registered_device *rdev, struct wireless_dev *result = NULL; bool have_ifidx = attrs[NL80211_ATTR_IFINDEX]; bool have_wdev_id = attrs[NL80211_ATTR_WDEV]; - u64 wdev_id; + u64 wdev_id = 0; int wiphy_idx = -1; int ifidx = -1;
Build currently fails with -Werror=maybe-uninitialized set: net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] Easy fix is to just initialize wdev_id to 0, since it's value doesn't otherwise matter unless have_wdev_id is true. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") CC: Johannes Berg <johannes@sipsolutions.net> CC: "David S. Miller" <davem@davemloft.net> CC: Jakub Kicinski <kuba@kernel.org> CC: linux-wireless@vger.kernel.org CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson <jarod@redhat.com> --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)