diff mbox series

phy: rockchip-typec: add missing of_node_put

Message ID 20210216084847.1544-1-angkery@163.com (mailing list archive)
State New, archived
Headers show
Series phy: rockchip-typec: add missing of_node_put | expand

Commit Message

Junlin Yang Feb. 16, 2021, 8:48 a.m. UTC 
From: Junlin Yang <yangjunlin@yulong.com>

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
 drivers/phy/rockchip/phy-rockchip-typec.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul March 15, 2021, 10:05 a.m. UTC | #1 
On 16-02-21, 16:48, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> Fix OF node leaks by calling of_node_put in
> for_each_available_child_of_node when the cycle returns.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
index 70a3125..d2bbdc9 100644
--- a/drivers/phy/rockchip/phy-rockchip-typec.c
+++ b/drivers/phy/rockchip/phy-rockchip-typec.c
@@ -1180,6 +1180,7 @@  static int rockchip_typec_phy_probe(struct platform_device *pdev)
 			dev_err(dev, "failed to create phy: %pOFn\n",
 				child_np);
 			pm_runtime_disable(dev);
+			of_node_put(child_np);
 			return PTR_ERR(phy);
 		}