| Message ID | 20210315150118.1770939-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f13b5e6bf283a086b6d5b47be1ecf05a341eb9b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ipa: make ipa_table_hash_support() inline | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 2 this patch: 2 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 22 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, Mar 15, 2021 at 8:01 AM Alex Elder <elder@linaro.org> wrote: > > In review, Alexander Duyck suggested that ipa_table_hash_support() > was trivial enough that it could be implemented as a static inline > function in the header file. But the patch had already been > accepted. Implement his suggestion. > > Signed-off-by: Alex Elder <elder@linaro.org> Looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com> > --- > drivers/net/ipa/ipa_table.c | 5 ----- > drivers/net/ipa/ipa_table.h | 5 ++++- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c > index baaab3dd0e63c..7450e27068f19 100644 > --- a/drivers/net/ipa/ipa_table.c > +++ b/drivers/net/ipa/ipa_table.c > @@ -239,11 +239,6 @@ static void ipa_table_validate_build(void) > > #endif /* !IPA_VALIDATE */ > > -bool ipa_table_hash_support(struct ipa *ipa) > -{ > - return ipa->version != IPA_VERSION_4_2; > -} > - > /* Zero entry count means no table, so just return a 0 address */ > static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16 count) > { > diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h > index 1a68d20f19d6a..889c2e93b1223 100644 > --- a/drivers/net/ipa/ipa_table.h > +++ b/drivers/net/ipa/ipa_table.h > @@ -55,7 +55,10 @@ static inline bool ipa_filter_map_valid(struct ipa *ipa, u32 filter_mask) > * ipa_table_hash_support() - Return true if hashed tables are supported > * @ipa: IPA pointer > */ > -bool ipa_table_hash_support(struct ipa *ipa); > +static inline bool ipa_table_hash_support(struct ipa *ipa) > +{ > + return ipa->version != IPA_VERSION_4_2; > +} > > /** > * ipa_table_reset() - Reset filter and route tables entries to "none" > -- > 2.27.0 >
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 15 Mar 2021 10:01:18 -0500 you wrote: > In review, Alexander Duyck suggested that ipa_table_hash_support() > was trivial enough that it could be implemented as a static inline > function in the header file. But the patch had already been > accepted. Implement his suggestion. > > Signed-off-by: Alex Elder <elder@linaro.org> > > [...] Here is the summary with links: - [net-next] net: ipa: make ipa_table_hash_support() inline https://git.kernel.org/netdev/net-next/c/0f13b5e6bf28 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c index baaab3dd0e63c..7450e27068f19 100644 --- a/drivers/net/ipa/ipa_table.c +++ b/drivers/net/ipa/ipa_table.c @@ -239,11 +239,6 @@ static void ipa_table_validate_build(void) #endif /* !IPA_VALIDATE */ -bool ipa_table_hash_support(struct ipa *ipa) -{ - return ipa->version != IPA_VERSION_4_2; -} - /* Zero entry count means no table, so just return a 0 address */ static dma_addr_t ipa_table_addr(struct ipa *ipa, bool filter_mask, u16 count) { diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h index 1a68d20f19d6a..889c2e93b1223 100644 --- a/drivers/net/ipa/ipa_table.h +++ b/drivers/net/ipa/ipa_table.h @@ -55,7 +55,10 @@ static inline bool ipa_filter_map_valid(struct ipa *ipa, u32 filter_mask) * ipa_table_hash_support() - Return true if hashed tables are supported * @ipa: IPA pointer */ -bool ipa_table_hash_support(struct ipa *ipa); +static inline bool ipa_table_hash_support(struct ipa *ipa) +{ + return ipa->version != IPA_VERSION_4_2; +} /** * ipa_table_reset() - Reset filter and route tables entries to "none"
In review, Alexander Duyck suggested that ipa_table_hash_support() was trivial enough that it could be implemented as a static inline function in the header file. But the patch had already been accepted. Implement his suggestion. Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/ipa_table.c | 5 ----- drivers/net/ipa/ipa_table.h | 5 ++++- 2 files changed, 4 insertions(+), 6 deletions(-)