diff mbox series

libkmod-config: more chars allowed as space

Message ID 20210310172652.13638-1-lucas.demarchi@intel.com (mailing list archive)
State New, archived
Headers show
Series libkmod-config: more chars allowed as space | expand

Commit Message

Lucas De Marchi March 10, 2021, 5:26 p.m. UTC 
Recently in a discussion I noticed that kernel allows more chars to be
considered as space in the kernel command line. Switch to the equivalent
of isspace() instead of considering only ' '.
---
 libkmod/libkmod-config.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Lucas De Marchi March 15, 2021, 8:25 p.m. UTC | #1 
On Wed, Mar 10, 2021 at 9:31 AM Lucas De Marchi
<lucas.demarchi@intel.com> wrote:
>
> Recently in a discussion I noticed that kernel allows more chars to be
> considered as space in the kernel command line. Switch to the equivalent
> of isspace() instead of considering only ' '.

Applied,

Lucas De Marchi

> ---
>  libkmod/libkmod-config.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
> index 2873f06..4fdd40f 100644
> --- a/libkmod/libkmod-config.c
> +++ b/libkmod/libkmod-config.c
> @@ -543,11 +543,14 @@ static int kmod_config_parse_kcmdline(struct kmod_config *config)
>
>                         break;
>                 case '\0':
> -               case '\n':
> -                       /* Stop iterating on new chars */
>                         iter = false;
>                         /* fall-through */
>                 case ' ':
> +               case '\n':
> +               case '\t':
> +               case '\v':
> +               case '\f':
> +               case '\r':
>                         if (is_quoted && state == STATE_VALUE) {
>                                 /* no state change*/;
>                         } else if (is_quoted) {
> --
> 2.30.1
>
diff mbox series

Patch

diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
index 2873f06..4fdd40f 100644
--- a/libkmod/libkmod-config.c
+++ b/libkmod/libkmod-config.c
@@ -543,11 +543,14 @@  static int kmod_config_parse_kcmdline(struct kmod_config *config)
 
 			break;
 		case '\0':
-		case '\n':
-			/* Stop iterating on new chars */
 			iter = false;
 			/* fall-through */
 		case ' ':
+		case '\n':
+		case '\t':
+		case '\v':
+		case '\f':
+		case '\r':
 			if (is_quoted && state == STATE_VALUE) {
 				/* no state change*/;
 			} else if (is_quoted) {