| Message ID | 20210315211400.2805330-4-tobias@waldekranz.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: mv88e6xxx: Offload bridge port flags | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 21 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, Mar 15, 2021 at 10:13:58PM +0100, Tobias Waldekranz wrote: > In accordance with the comment in dsa_port_bridge_leave, standalone > ports shall be configured to flood all types of traffic. This change > aligns the mv88e6xxx driver with that policy. > > Previously a standalone port would initially not egress any unknown > traffic, but after joining and then leaving a bridge, it would. > > This does not matter that much since we only ever send FROM_CPUs on > standalone ports, but it seems prudent to make sure that the initial > values match those that are applied after a bridging/unbridging cycle. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
On 3/15/2021 2:13 PM, Tobias Waldekranz wrote: > In accordance with the comment in dsa_port_bridge_leave, standalone > ports shall be configured to flood all types of traffic. This change > aligns the mv88e6xxx driver with that policy. > > Previously a standalone port would initially not egress any unknown > traffic, but after joining and then leaving a bridge, it would. > > This does not matter that much since we only ever send FROM_CPUs on > standalone ports, but it seems prudent to make sure that the initial > values match those that are applied after a bridging/unbridging cycle. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Mon, Mar 15, 2021 at 10:13:58PM +0100, Tobias Waldekranz wrote: > In accordance with the comment in dsa_port_bridge_leave, standalone > ports shall be configured to flood all types of traffic. This change > aligns the mv88e6xxx driver with that policy. > > Previously a standalone port would initially not egress any unknown > traffic, but after joining and then leaving a bridge, it would. > > This does not matter that much since we only ever send FROM_CPUs on > standalone ports, but it seems prudent to make sure that the initial > values match those that are applied after a bridging/unbridging cycle. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 86027e98d83d..01e4ac32d1e5 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2457,19 +2457,15 @@ static int mv88e6xxx_setup_message_port(struct mv88e6xxx_chip *chip, int port) static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port) { - struct dsa_switch *ds = chip->ds; - bool flood; int err; - /* Upstream ports flood frames with unknown unicast or multicast DA */ - flood = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port); if (chip->info->ops->port_set_ucast_flood) { - err = chip->info->ops->port_set_ucast_flood(chip, port, flood); + err = chip->info->ops->port_set_ucast_flood(chip, port, true); if (err) return err; } if (chip->info->ops->port_set_mcast_flood) { - err = chip->info->ops->port_set_mcast_flood(chip, port, flood); + err = chip->info->ops->port_set_mcast_flood(chip, port, true); if (err) return err; }
In accordance with the comment in dsa_port_bridge_leave, standalone ports shall be configured to flood all types of traffic. This change aligns the mv88e6xxx driver with that policy. Previously a standalone port would initially not egress any unknown traffic, but after joining and then leaving a bridge, it would. This does not matter that much since we only ever send FROM_CPUs on standalone ports, but it seems prudent to make sure that the initial values match those that are applied after a bridging/unbridging cycle. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)