| Message ID | 1615886833-71688-4-git-send-email-hkelam@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2: miscellaneous fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | fail | 1 blamed authors not CCed: george.cherian@marvell.com; 1 maintainers not CCed: george.cherian@marvell.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | fail | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 25 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > From: Subbaraya Sundeep <sbhatta@marvell.com> > > Memory for driver private structure rvu_devlink is > also allocated during devlink_alloc. Hence use > the allocated memory by devlink_alloc and access it > by devlink_priv call. > > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver") > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> Does it fix any bug? Looks like a coding improvement.
Hi Jakub, On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > > From: Subbaraya Sundeep <sbhatta@marvell.com> > > > > Memory for driver private structure rvu_devlink is > > also allocated during devlink_alloc. Hence use > > the allocated memory by devlink_alloc and access it > > by devlink_priv call. > > > > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver") > > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > > Does it fix any bug? Looks like a coding improvement. Without this we cannot fetch our private struct 'rvu_devlink' from any of the functions in devlink_ops which may get added in future. Thanks, Sundeep
On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote: > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > > > From: Subbaraya Sundeep <sbhatta@marvell.com> > > > > > > Memory for driver private structure rvu_devlink is > > > also allocated during devlink_alloc. Hence use > > > the allocated memory by devlink_alloc and access it > > > by devlink_priv call. > > > > > > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver") > > > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > > > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > > > > Does it fix any bug? Looks like a coding improvement. > > Without this we cannot fetch our private struct 'rvu_devlink' from any > of the functions in devlink_ops which may get added in future. "which may get added in future" does not sound like it's fixing an existing problem to me :( If you have particular case where the existing setup is problematic please describe it in more detail, or mention what other fix depends on this patch. Otherwise sending this one patch for net-next would be better IMHO.
On Wed, Mar 17, 2021 at 1:57 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote: > > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski <kuba@kernel.org> wrote: > > > > > > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > > > > From: Subbaraya Sundeep <sbhatta@marvell.com> > > > > > > > > Memory for driver private structure rvu_devlink is > > > > also allocated during devlink_alloc. Hence use > > > > the allocated memory by devlink_alloc and access it > > > > by devlink_priv call. > > > > > > > > Fixes: fae06da4("octeontx2-af: Add devlink suppoort to af driver") > > > > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> > > > > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com> > > > > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com> > > > > > > Does it fix any bug? Looks like a coding improvement. > > > > Without this we cannot fetch our private struct 'rvu_devlink' from any > > of the functions in devlink_ops which may get added in future. > > "which may get added in future" does not sound like it's fixing > an existing problem to me :( > > If you have particular case where the existing setup is problematic > please describe it in more detail, or mention what other fix depends > on this patch. Otherwise sending this one patch for net-next would > be better IMHO. Sure will send this one patch to net-next. Thanks, Sundeep
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c index 10a98bc..d88ac90 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c @@ -1380,14 +1380,9 @@ int rvu_register_dl(struct rvu *rvu) struct devlink *dl; int err; - rvu_dl = kzalloc(sizeof(*rvu_dl), GFP_KERNEL); - if (!rvu_dl) - return -ENOMEM; - dl = devlink_alloc(&rvu_devlink_ops, sizeof(struct rvu_devlink)); if (!dl) { dev_warn(rvu->dev, "devlink_alloc failed\n"); - kfree(rvu_dl); return -ENOMEM; } @@ -1395,10 +1390,10 @@ int rvu_register_dl(struct rvu *rvu) if (err) { dev_err(rvu->dev, "devlink register failed with error %d\n", err); devlink_free(dl); - kfree(rvu_dl); return err; } + rvu_dl = devlink_priv(dl); rvu_dl->dl = dl; rvu_dl->rvu = rvu; rvu->rvu_dl = rvu_dl;