| Message ID | 20210311192746.7362-1-heiko.thiery@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: configs: Enable PCIe support for imx8mq boards | expand |
On Thu, Mar 11, 2021 at 08:27:47PM +0100, Heiko Thiery wrote: > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > v2: > - slightly modified the commit message (Fabio Estevam) > > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 1f673b00c5f5..522bae6a8f21 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y > CONFIG_PCI_HOST_THUNDER_ECAM=y > CONFIG_PCIE_ROCKCHIP_HOST=m > CONFIG_PCIE_BRCMSTB=m > +CONFIG_PCI_IMX6=y Do we really want it to be built-in? If so, it would be nice to have some comments about that in commit log. Shawn > CONFIG_PCI_LAYERSCAPE=y > CONFIG_PCIE_LAYERSCAPE_GEN4=y > CONFIG_PCI_HISI=y > -- > 2.30.0 >
Hi Shawn, Am Mi., 17. März 2021 um 09:02 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > On Thu, Mar 11, 2021 at 08:27:47PM +0100, Heiko Thiery wrote: > > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, > > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > --- > > v2: > > - slightly modified the commit message (Fabio Estevam) > > > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 1f673b00c5f5..522bae6a8f21 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y > > CONFIG_PCI_HOST_THUNDER_ECAM=y > > CONFIG_PCIE_ROCKCHIP_HOST=m > > CONFIG_PCIE_BRCMSTB=m > > +CONFIG_PCI_IMX6=y > > Do we really want it to be built-in? If so, it would be nice to have some > comments about that in commit log. Why would you not want it? I see other SOC PCI controllers are also enabled. I would like to have it because we have an Intel e1000 on our pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we would have the PCI support with the default defconfig. On the NXP imx8mq EVK a m.2 is connected to the PCI interface. Is this the kind of comments you want? > Shawn > > > CONFIG_PCI_LAYERSCAPE=y > > CONFIG_PCIE_LAYERSCAPE_GEN4=y > > CONFIG_PCI_HISI=y > > -- > > 2.30.0 > > BR
Hi Shawn, Am Mi., 17. März 2021 um 12:52 Uhr schrieb Heiko Thiery <heiko.thiery@gmail.com>: > > Hi Shawn, > > Am Mi., 17. März 2021 um 09:02 Uhr schrieb Shawn Guo <shawnguo@kernel.org>: > > > > On Thu, Mar 11, 2021 at 08:27:47PM +0100, Heiko Thiery wrote: > > > Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, > > > imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. > > > > > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > > > --- > > > v2: > > > - slightly modified the commit message (Fabio Estevam) > > > > > > arch/arm64/configs/defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index 1f673b00c5f5..522bae6a8f21 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y > > > CONFIG_PCI_HOST_THUNDER_ECAM=y > > > CONFIG_PCIE_ROCKCHIP_HOST=m > > > CONFIG_PCIE_BRCMSTB=m > > > +CONFIG_PCI_IMX6=y > > > > Do we really want it to be built-in? If so, it would be nice to have some > > comments about that in commit log. Or do you mean why it cannot be enabled as a module? The PCI_IMX6 driver is only a bool option in the Kconfig and cannot be built as a module. So it is required to have it built-in. > > Why would you not want it? I see other SOC PCI controllers are also > enabled. I would like to have it because we have an Intel e1000 on our > pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we > would have the PCI support with the default defconfig. On the NXP > imx8mq EVK a m.2 is connected to the PCI interface. > > Is this the kind of comments you want? > > > Shawn > > > > > CONFIG_PCI_LAYERSCAPE=y > > > CONFIG_PCIE_LAYERSCAPE_GEN4=y > > > CONFIG_PCI_HISI=y > > > -- > > > 2.30.0 > > > > > BR > -- > Heiko > -- > Heiko
Hi Heiko, On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > Do we really want it to be built-in? If so, it would be nice to have some > > comments about that in commit log. > > Why would you not want it? I see other SOC PCI controllers are also > enabled. I would like to have it because we have an Intel e1000 on our > pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we > would have the PCI support with the default defconfig. On the NXP > imx8mq EVK a m.2 is connected to the PCI interface. > > Is this the kind of comments you want? You have selected the driver to be built-in: CONFIG_PCI_IMX6=y Shawn's question is why it needs to be built-in instead of a kernel module: CONFIG_PCI_IMX6=m On arch/arm64/configs/defconfig the preference is to select the options as modules, whenever possible. If it can't be a module and needs to be built-in, then please provide a justification in the commit log. Hope this can clarify.
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 1f673b00c5f5..522bae6a8f21 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -225,6 +225,7 @@ CONFIG_PCI_HOST_THUNDER_PEM=y CONFIG_PCI_HOST_THUNDER_ECAM=y CONFIG_PCIE_ROCKCHIP_HOST=m CONFIG_PCIE_BRCMSTB=m +CONFIG_PCI_IMX6=y CONFIG_PCI_LAYERSCAPE=y CONFIG_PCIE_LAYERSCAPE_GEN4=y CONFIG_PCI_HISI=y
Enable PCI_IMX6 to get PCI support for imx8mq boards like imx8mq-evk, imx8mq-kontron-pitx-imx8m and imx8mq-zii-ultra. Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- v2: - slightly modified the commit message (Fabio Estevam) arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)