mbox series

[0/1] btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+

Message ID 20210317200144.1067314-1-ngompa@fedoraproject.org (mailing list archive)
Headers show
Series btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+ | expand

Message

Neal Gompa March 17, 2021, 8:01 p.m. UTC
This is a patch requesting all substantial copyright owners to sign off
on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
to resolve various concerns around the mixture of code in btrfs-progs
with libbtrfsutil.

Each significant (i.e. non-trivial) commit author has been CC'd to
request their sign-off on this. Please reply to this to acknowledge
whether or not this is acceptable for your code.

Neal Gompa (1):
  btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+

 libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
 libbtrfsutil/COPYING.LESSER       |  165 -----
 libbtrfsutil/btrfsutil.h          |    2 +-
 libbtrfsutil/btrfsutil_internal.h |    2 +-
 libbtrfsutil/errors.c             |    2 +-
 libbtrfsutil/filesystem.c         |    2 +-
 libbtrfsutil/python/btrfsutilpy.h |    2 +-
 libbtrfsutil/python/error.c       |    2 +-
 libbtrfsutil/python/filesystem.c  |    2 +-
 libbtrfsutil/python/module.c      |    2 +-
 libbtrfsutil/python/qgroup.c      |    2 +-
 libbtrfsutil/python/setup.py      |    4 +-
 libbtrfsutil/python/subvolume.c   |    2 +-
 libbtrfsutil/qgroup.c             |    2 +-
 libbtrfsutil/stubs.c              |    2 +-
 libbtrfsutil/stubs.h              |    2 +-
 libbtrfsutil/subvolume.c          |    2 +-
 17 files changed, 495 insertions(+), 832 deletions(-)
 delete mode 100644 libbtrfsutil/COPYING.LESSER

Comments

Omar Sandoval March 17, 2021, 9:23 p.m. UTC | #1
On Wed, Mar 17, 2021 at 04:01:43PM -0400, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.
> 
> Neal Gompa (1):
>   btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
> 
>  libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
>  libbtrfsutil/COPYING.LESSER       |  165 -----
>  libbtrfsutil/btrfsutil.h          |    2 +-
>  libbtrfsutil/btrfsutil_internal.h |    2 +-
>  libbtrfsutil/errors.c             |    2 +-
>  libbtrfsutil/filesystem.c         |    2 +-
>  libbtrfsutil/python/btrfsutilpy.h |    2 +-
>  libbtrfsutil/python/error.c       |    2 +-
>  libbtrfsutil/python/filesystem.c  |    2 +-
>  libbtrfsutil/python/module.c      |    2 +-
>  libbtrfsutil/python/qgroup.c      |    2 +-
>  libbtrfsutil/python/setup.py      |    4 +-
>  libbtrfsutil/python/subvolume.c   |    2 +-
>  libbtrfsutil/qgroup.c             |    2 +-
>  libbtrfsutil/stubs.c              |    2 +-
>  libbtrfsutil/stubs.h              |    2 +-
>  libbtrfsutil/subvolume.c          |    2 +-
>  17 files changed, 495 insertions(+), 832 deletions(-)
>  delete mode 100644 libbtrfsutil/COPYING.LESSER

Acked-by: Omar Sandoval <osandov@fb.com>
Tomohiro Misono (Fujitsu) March 18, 2021, 12:19 a.m. UTC | #2
> Subject: [PATCH 0/1] btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
> 
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.

Hello,

No objections from me. 
 Acked-by: Misono Tomhiro <misono.tomohiro@jp.fujitsu.com>

Thanks,
Misono

> 
> Neal Gompa (1):
>   btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
> 
>  libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
>  libbtrfsutil/COPYING.LESSER       |  165 -----
>  libbtrfsutil/btrfsutil.h          |    2 +-
>  libbtrfsutil/btrfsutil_internal.h |    2 +-
>  libbtrfsutil/errors.c             |    2 +-
>  libbtrfsutil/filesystem.c         |    2 +-
>  libbtrfsutil/python/btrfsutilpy.h |    2 +-
>  libbtrfsutil/python/error.c       |    2 +-
>  libbtrfsutil/python/filesystem.c  |    2 +-
>  libbtrfsutil/python/module.c      |    2 +-
>  libbtrfsutil/python/qgroup.c      |    2 +-
>  libbtrfsutil/python/setup.py      |    4 +-
>  libbtrfsutil/python/subvolume.c   |    2 +-
>  libbtrfsutil/qgroup.c             |    2 +-
>  libbtrfsutil/stubs.c              |    2 +-
>  libbtrfsutil/stubs.h              |    2 +-
>  libbtrfsutil/subvolume.c          |    2 +-
>  17 files changed, 495 insertions(+), 832 deletions(-)
>  delete mode 100644 libbtrfsutil/COPYING.LESSER
> 
> --
> 2.30.2
Qu Wenruo March 18, 2021, 12:32 a.m. UTC | #3
On 2021/3/18 上午4:01, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
>
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.

I'm a little surprised that I got CCed, as I can't remember any
contribution from me to libbtrfstuil.

But still the license change looks OK to me.

Acked-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

>
> Neal Gompa (1):
>    btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
>
>   libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
>   libbtrfsutil/COPYING.LESSER       |  165 -----
>   libbtrfsutil/btrfsutil.h          |    2 +-
>   libbtrfsutil/btrfsutil_internal.h |    2 +-
>   libbtrfsutil/errors.c             |    2 +-
>   libbtrfsutil/filesystem.c         |    2 +-
>   libbtrfsutil/python/btrfsutilpy.h |    2 +-
>   libbtrfsutil/python/error.c       |    2 +-
>   libbtrfsutil/python/filesystem.c  |    2 +-
>   libbtrfsutil/python/module.c      |    2 +-
>   libbtrfsutil/python/qgroup.c      |    2 +-
>   libbtrfsutil/python/setup.py      |    4 +-
>   libbtrfsutil/python/subvolume.c   |    2 +-
>   libbtrfsutil/qgroup.c             |    2 +-
>   libbtrfsutil/stubs.c              |    2 +-
>   libbtrfsutil/stubs.h              |    2 +-
>   libbtrfsutil/subvolume.c          |    2 +-
>   17 files changed, 495 insertions(+), 832 deletions(-)
>   delete mode 100644 libbtrfsutil/COPYING.LESSER
>
Marcos Paulo de Souza March 18, 2021, 11:46 a.m. UTC | #4
On Wed, 2021-03-17 at 16:01 -0400, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign
> off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in
> order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.
> 
> Neal Gompa (1):
>   btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+

Acked-by: Marcos Paulo de Souza <mpdesouza@suse.com>

> 
>  libbtrfsutil/COPYING              | 1130 ++++++++++++---------------
> --
>  libbtrfsutil/COPYING.LESSER       |  165 -----
>  libbtrfsutil/btrfsutil.h          |    2 +-
>  libbtrfsutil/btrfsutil_internal.h |    2 +-
>  libbtrfsutil/errors.c             |    2 +-
>  libbtrfsutil/filesystem.c         |    2 +-
>  libbtrfsutil/python/btrfsutilpy.h |    2 +-
>  libbtrfsutil/python/error.c       |    2 +-
>  libbtrfsutil/python/filesystem.c  |    2 +-
>  libbtrfsutil/python/module.c      |    2 +-
>  libbtrfsutil/python/qgroup.c      |    2 +-
>  libbtrfsutil/python/setup.py      |    4 +-
>  libbtrfsutil/python/subvolume.c   |    2 +-
>  libbtrfsutil/qgroup.c             |    2 +-
>  libbtrfsutil/stubs.c              |    2 +-
>  libbtrfsutil/stubs.h              |    2 +-
>  libbtrfsutil/subvolume.c          |    2 +-
>  17 files changed, 495 insertions(+), 832 deletions(-)
>  delete mode 100644 libbtrfsutil/COPYING.LESSER
>
Anand Jain March 18, 2021, 12:50 p.m. UTC | #5
On 18/03/2021 04:01, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.
> 
> Neal Gompa (1):
>    btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
> 
>   libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
>   libbtrfsutil/COPYING.LESSER       |  165 -----
>   libbtrfsutil/btrfsutil.h          |    2 +-
>   libbtrfsutil/btrfsutil_internal.h |    2 +-
>   libbtrfsutil/errors.c             |    2 +-
>   libbtrfsutil/filesystem.c         |    2 +-
>   libbtrfsutil/python/btrfsutilpy.h |    2 +-
>   libbtrfsutil/python/error.c       |    2 +-
>   libbtrfsutil/python/filesystem.c  |    2 +-
>   libbtrfsutil/python/module.c      |    2 +-
>   libbtrfsutil/python/qgroup.c      |    2 +-
>   libbtrfsutil/python/setup.py      |    4 +-
>   libbtrfsutil/python/subvolume.c   |    2 +-
>   libbtrfsutil/qgroup.c             |    2 +-
>   libbtrfsutil/stubs.c              |    2 +-
>   libbtrfsutil/stubs.h              |    2 +-
>   libbtrfsutil/subvolume.c          |    2 +-
>   17 files changed, 495 insertions(+), 832 deletions(-)
>   delete mode 100644 libbtrfsutil/COPYING.LESSER
> 

Acked-by: Anand Jain <anand.jain@oracle.com>
David Sterba March 18, 2021, 3:47 p.m. UTC | #6
On Thu, Mar 18, 2021 at 08:32:30AM +0800, Qu Wenruo wrote:
> 
> 
> On 2021/3/18 上午4:01, Neal Gompa wrote:
> > This is a patch requesting all substantial copyright owners to sign off
> > on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> > to resolve various concerns around the mixture of code in btrfs-progs
> > with libbtrfsutil.
> >
> > Each significant (i.e. non-trivial) commit author has been CC'd to
> > request their sign-off on this. Please reply to this to acknowledge
> > whether or not this is acceptable for your code.
> 
> I'm a little surprised that I got CCed, as I can't remember any
> contribution from me to libbtrfstuil.

$ git log --oneline --author=wqu libbtrfsutil
f01d2b85581e libbtrfsutil: Convert to designated initialization for SubvolumeIterator_type
425c950cc6fe libbtrfsutil: Convert to designated initialization for QgroupInherit_type
a528cbeead1c libbtrfsutil: Convert to designated initialization for BtrfsUtilError_type
Zygo Blaxell March 23, 2021, 12:57 a.m. UTC | #7
On Wed, Mar 17, 2021 at 04:01:43PM -0400, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.

Acked-by: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>

> Neal Gompa (1):
>   btrfs-progs: libbtrfsutil: Relicense to LGPLv2.1+
> 
>  libbtrfsutil/COPYING              | 1130 ++++++++++++-----------------
>  libbtrfsutil/COPYING.LESSER       |  165 -----
>  libbtrfsutil/btrfsutil.h          |    2 +-
>  libbtrfsutil/btrfsutil_internal.h |    2 +-
>  libbtrfsutil/errors.c             |    2 +-
>  libbtrfsutil/filesystem.c         |    2 +-
>  libbtrfsutil/python/btrfsutilpy.h |    2 +-
>  libbtrfsutil/python/error.c       |    2 +-
>  libbtrfsutil/python/filesystem.c  |    2 +-
>  libbtrfsutil/python/module.c      |    2 +-
>  libbtrfsutil/python/qgroup.c      |    2 +-
>  libbtrfsutil/python/setup.py      |    4 +-
>  libbtrfsutil/python/subvolume.c   |    2 +-
>  libbtrfsutil/qgroup.c             |    2 +-
>  libbtrfsutil/stubs.c              |    2 +-
>  libbtrfsutil/stubs.h              |    2 +-
>  libbtrfsutil/subvolume.c          |    2 +-
>  17 files changed, 495 insertions(+), 832 deletions(-)
>  delete mode 100644 libbtrfsutil/COPYING.LESSER
> 
> -- 
> 2.30.2
>
David Sterba March 23, 2021, 3:50 p.m. UTC | #8
On Wed, Mar 17, 2021 at 04:01:43PM -0400, Neal Gompa wrote:
> This is a patch requesting all substantial copyright owners to sign off
> on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> to resolve various concerns around the mixture of code in btrfs-progs
> with libbtrfsutil.
> 
> Each significant (i.e. non-trivial) commit author has been CC'd to
> request their sign-off on this. Please reply to this to acknowledge
> whether or not this is acceptable for your code.

Thanks! I think we have acks for all non-trivial contirbutions. For the
record, the trivial one are:

* dbf60b488e3b ("libbtrfsutil: update btrfs_util_delete_subvolume docs")
  a comment update, clarifying usage

* 2e67bf0ed69d ("btrfs-progs: docs: fix typos in READMEs, INSTALL and * CHANGES")
* b1d39a42a4ef ("btrfs-progs: fix typos in comments")
  treewide comment typo fixes

* 01e35d9f53eb ("btrfs-progs: treewide: Fix missing declarations")
  code changes, but adding static or missing includes

* 9fd37f951be6 ("btrfs-progs: complete the implementation RAID1C34 definitions")
  copied definitions from kernel code

I'm not sure about the commit adding pkg-config spec file, it's not code
but it's beyond what I'd consider trivial. I've added Sheng Mao to CC,
please acknowledge the change.

* 4498fe1a2a7c ("libbtrfsutil: add pkg-config spec file")

I'll update the changelog with all the reasons for relicensing that have
been brought up.
Neal Gompa March 30, 2021, 1:21 p.m. UTC | #9
On Tue, Mar 23, 2021 at 11:53 AM David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Mar 17, 2021 at 04:01:43PM -0400, Neal Gompa wrote:
> > This is a patch requesting all substantial copyright owners to sign off
> > on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> > to resolve various concerns around the mixture of code in btrfs-progs
> > with libbtrfsutil.
> >
> > Each significant (i.e. non-trivial) commit author has been CC'd to
> > request their sign-off on this. Please reply to this to acknowledge
> > whether or not this is acceptable for your code.
>
> Thanks! I think we have acks for all non-trivial contirbutions. For the
> record, the trivial one are:
>
> * dbf60b488e3b ("libbtrfsutil: update btrfs_util_delete_subvolume docs")
>   a comment update, clarifying usage
>
> * 2e67bf0ed69d ("btrfs-progs: docs: fix typos in READMEs, INSTALL and * CHANGES")
> * b1d39a42a4ef ("btrfs-progs: fix typos in comments")
>   treewide comment typo fixes
>
> * 01e35d9f53eb ("btrfs-progs: treewide: Fix missing declarations")
>   code changes, but adding static or missing includes
>
> * 9fd37f951be6 ("btrfs-progs: complete the implementation RAID1C34 definitions")
>   copied definitions from kernel code
>
> I'm not sure about the commit adding pkg-config spec file, it's not code
> but it's beyond what I'd consider trivial. I've added Sheng Mao to CC,
> please acknowledge the change.
>
> * 4498fe1a2a7c ("libbtrfsutil: add pkg-config spec file")
>
> I'll update the changelog with all the reasons for relicensing that have
> been brought up.

I consider that trivial because the only actual part in libbtrfsutil
is the pc file, which is a trivial templated data file (I had one that
I was preparing to send that looked exactly like it, but Sheng Mao
beat me to the punch). The autofoo is part of the parent btrfs-progs
project and is already correctly licensed anyway.
David Sterba April 16, 2021, 7:05 p.m. UTC | #10
On Tue, Mar 30, 2021 at 09:21:40AM -0400, Neal Gompa wrote:
> On Tue, Mar 23, 2021 at 11:53 AM David Sterba <dsterba@suse.cz> wrote:
> >
> > On Wed, Mar 17, 2021 at 04:01:43PM -0400, Neal Gompa wrote:
> > > This is a patch requesting all substantial copyright owners to sign off
> > > on changing the license of the libbtrfsutil code to LGPLv2.1+ in order
> > > to resolve various concerns around the mixture of code in btrfs-progs
> > > with libbtrfsutil.
> > >
> > > Each significant (i.e. non-trivial) commit author has been CC'd to
> > > request their sign-off on this. Please reply to this to acknowledge
> > > whether or not this is acceptable for your code.
> >
> > Thanks! I think we have acks for all non-trivial contirbutions. For the
> > record, the trivial one are:
> >
> > * dbf60b488e3b ("libbtrfsutil: update btrfs_util_delete_subvolume docs")
> >   a comment update, clarifying usage
> >
> > * 2e67bf0ed69d ("btrfs-progs: docs: fix typos in READMEs, INSTALL and * CHANGES")
> > * b1d39a42a4ef ("btrfs-progs: fix typos in comments")
> >   treewide comment typo fixes
> >
> > * 01e35d9f53eb ("btrfs-progs: treewide: Fix missing declarations")
> >   code changes, but adding static or missing includes
> >
> > * 9fd37f951be6 ("btrfs-progs: complete the implementation RAID1C34 definitions")
> >   copied definitions from kernel code
> >
> > I'm not sure about the commit adding pkg-config spec file, it's not code
> > but it's beyond what I'd consider trivial. I've added Sheng Mao to CC,
> > please acknowledge the change.
> >
> > * 4498fe1a2a7c ("libbtrfsutil: add pkg-config spec file")
> >
> > I'll update the changelog with all the reasons for relicensing that have
> > been brought up.
> 
> I consider that trivial because the only actual part in libbtrfsutil
> is the pc file, which is a trivial templated data file (I had one that
> I was preparing to send that looked exactly like it, but Sheng Mao
> beat me to the punch). The autofoo is part of the parent btrfs-progs
> project and is already correctly licensed anyway.

Fair enough. Then there's nothing left to addresss, thanks.