| Message ID | 20210318124422.3200180-6-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Rid W=1 warnings in Crypto | expand |
On Thu, 2021-03-18 at 12:44 +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead > drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead > drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead > drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead > > Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> > Cc: Declan Murphy <declan.murphy@intel.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> Thanks for the fix! > drivers/crypto/keembay/ocs-hcu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c > index 81eecacf603ad..deb9bd460ee62 100644 > --- a/drivers/crypto/keembay/ocs-hcu.c > +++ b/drivers/crypto/keembay/ocs-hcu.c > @@ -93,7 +93,7 @@ > #define OCS_HCU_WAIT_BUSY_TIMEOUT_US 1000000 > > /** > - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list. > + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list. > * @src_addr: Source address of the data. > * @src_len: Length of data to be fetched. > * @nxt_desc: Next descriptor to fetch. > @@ -107,7 +107,7 @@ struct ocs_hcu_dma_entry { > }; > > /** > - * struct ocs_dma_list - OCS-specific DMA linked list. > + * struct ocs_hcu_dma_list - OCS-specific DMA linked list. > * @head: The head of the list (points to the array backing the list). > * @tail: The current tail of the list; NULL if the list is empty. > * @dma_addr: The DMA address of @head (i.e., the DMA address of the backing > @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo) > } > > /** > - * ocs_hcu_digest() - Perform a hashing iteration. > + * ocs_hcu_hash_update() - Perform a hashing iteration. > * @hcu_dev: The OCS HCU device to use. > * @ctx: The OCS HCU hashing context. > * @dma_list: The OCS DMA list mapping the input data to process. > @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev, > } > > /** > - * ocs_hcu_hash_final() - Update and finalize hash computation. > + * ocs_hcu_hash_finup() - Update and finalize hash computation. > * @hcu_dev: The OCS HCU device to use. > * @ctx: The OCS HCU hashing context. > * @dma_list: The OCS DMA list mapping the input data to process.
diff --git a/drivers/crypto/keembay/ocs-hcu.c b/drivers/crypto/keembay/ocs-hcu.c index 81eecacf603ad..deb9bd460ee62 100644 --- a/drivers/crypto/keembay/ocs-hcu.c +++ b/drivers/crypto/keembay/ocs-hcu.c @@ -93,7 +93,7 @@ #define OCS_HCU_WAIT_BUSY_TIMEOUT_US 1000000 /** - * struct ocs_hcu_dma_list - An entry in an OCS DMA linked list. + * struct ocs_hcu_dma_entry - An entry in an OCS DMA linked list. * @src_addr: Source address of the data. * @src_len: Length of data to be fetched. * @nxt_desc: Next descriptor to fetch. @@ -107,7 +107,7 @@ struct ocs_hcu_dma_entry { }; /** - * struct ocs_dma_list - OCS-specific DMA linked list. + * struct ocs_hcu_dma_list - OCS-specific DMA linked list. * @head: The head of the list (points to the array backing the list). * @tail: The current tail of the list; NULL if the list is empty. * @dma_addr: The DMA address of @head (i.e., the DMA address of the backing @@ -597,7 +597,7 @@ int ocs_hcu_hash_init(struct ocs_hcu_hash_ctx *ctx, enum ocs_hcu_algo algo) } /** - * ocs_hcu_digest() - Perform a hashing iteration. + * ocs_hcu_hash_update() - Perform a hashing iteration. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process. @@ -632,7 +632,7 @@ int ocs_hcu_hash_update(struct ocs_hcu_dev *hcu_dev, } /** - * ocs_hcu_hash_final() - Update and finalize hash computation. + * ocs_hcu_hash_finup() - Update and finalize hash computation. * @hcu_dev: The OCS HCU device to use. * @ctx: The OCS HCU hashing context. * @dma_list: The OCS DMA list mapping the input data to process.
Fixes the following W=1 kernel build warning(s): drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> Cc: Declan Murphy <declan.murphy@intel.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/crypto/keembay/ocs-hcu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)