| Message ID | 20210318032840.7611-7-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | qla2xxx patches for kernel v5.12 and v5.13 | expand |
On Wed, Mar 17, 2021 at 08:28:40PM -0700, Bart Van Assche wrote: > @@ -2873,7 +2875,9 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost) > } > > /* reset firmware statistics */ > - qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); > + rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); > + ql_log(ql_log_warn, vha, 0x70d9, > + "Resetting ISP statistics failed: rval = %d\n", rval); Is there not an 'if' missing? if (rval) ql_log(...)
On 3/18/21 1:08 AM, Daniel Wagner wrote: > On Wed, Mar 17, 2021 at 08:28:40PM -0700, Bart Van Assche wrote: >> @@ -2873,7 +2875,9 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost) >> } >> >> /* reset firmware statistics */ >> - qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); >> + rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); >> + ql_log(ql_log_warn, vha, 0x70d9, >> + "Resetting ISP statistics failed: rval = %d\n", rval); > > Is there not an 'if' missing? > > if (rval) > ql_log(...) Right, I will add an if-statement. Thanks, Bart.
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 63391c9be05d..5813b17f1633 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -2864,6 +2864,8 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost) vha->qla_stats.jiffies_at_last_reset = get_jiffies_64(); if (IS_FWI2_CAPABLE(ha)) { + int rval; + stats = dma_alloc_coherent(&ha->pdev->dev, sizeof(*stats), &stats_dma, GFP_KERNEL); if (!stats) { @@ -2873,7 +2875,9 @@ qla2x00_reset_host_stats(struct Scsi_Host *shost) } /* reset firmware statistics */ - qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); + rval = qla24xx_get_isp_stats(base_vha, stats, stats_dma, BIT_0); + ql_log(ql_log_warn, vha, 0x70d9, + "Resetting ISP statistics failed: rval = %d\n", rval); dma_free_coherent(&ha->pdev->dev, sizeof(*stats), stats, stats_dma);
This patch fixes the following Coverity warning: CID 361199 (#1 of 1): Unchecked return value (CHECKED_RETURN) 3. check_return: Calling qla24xx_get_isp_stats without checking return value (as is done elsewhere 4 out of 5 times). Cc: Quinn Tran <qutran@marvell.com> Cc: Mike Christie <michael.christie@oracle.com> Cc: Himanshu Madhani <himanshu.madhani@oracle.com> Cc: Daniel Wagner <dwagner@suse.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_attr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)