| Message ID | 20210313104214.1548076-1-slyfox@gentoo.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | ia64: fix format string for ia64-acpi-cpu-freq | expand |
On 13-03-21, 10:42, Sergei Trofimovich wrote: > Fix warning with %lx / s64 mismatch: > > CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o > drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate': > warning: format '%lx' expects argument of type 'long unsigned int', > but argument 3 has type 's64' {aka 'long long int'} [-Wformat=] > > CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> > CC: Viresh Kumar <viresh.kumar@linaro.org> > CC: linux-pm@vger.kernel.org > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > --- > drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c > index 2efe7189ccc4..c6bdc455517f 100644 > --- a/drivers/cpufreq/ia64-acpi-cpufreq.c > +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c > @@ -54,7 +54,7 @@ processor_set_pstate ( > retval = ia64_pal_set_pstate((u64)value); > > if (retval) { > - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n", > + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n", > value, retval); > return -ENODEV; > } > @@ -77,7 +77,7 @@ processor_get_pstate ( > > if (retval) > pr_debug("Failed to get current freq with " > - "error 0x%lx, idx 0x%x\n", retval, *value); > + "error 0x%llx, idx 0x%x\n", retval, *value); > > return (int)retval; > } Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, Mar 15, 2021 at 4:19 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 13-03-21, 10:42, Sergei Trofimovich wrote: > > Fix warning with %lx / s64 mismatch: > > > > CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o > > drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate': > > warning: format '%lx' expects argument of type 'long unsigned int', > > but argument 3 has type 's64' {aka 'long long int'} [-Wformat=] > > > > CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > CC: Viresh Kumar <viresh.kumar@linaro.org> > > CC: linux-pm@vger.kernel.org > > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> > > --- > > drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c > > index 2efe7189ccc4..c6bdc455517f 100644 > > --- a/drivers/cpufreq/ia64-acpi-cpufreq.c > > +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c > > @@ -54,7 +54,7 @@ processor_set_pstate ( > > retval = ia64_pal_set_pstate((u64)value); > > > > if (retval) { > > - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n", > > + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n", > > value, retval); > > return -ENODEV; > > } > > @@ -77,7 +77,7 @@ processor_get_pstate ( > > > > if (retval) > > pr_debug("Failed to get current freq with " > > - "error 0x%lx, idx 0x%x\n", retval, *value); > > + "error 0x%llx, idx 0x%x\n", retval, *value); > > > > return (int)retval; > > } > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Applied as 5.13 material, thanks!
diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c index 2efe7189ccc4..c6bdc455517f 100644 --- a/drivers/cpufreq/ia64-acpi-cpufreq.c +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c @@ -54,7 +54,7 @@ processor_set_pstate ( retval = ia64_pal_set_pstate((u64)value); if (retval) { - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n", + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n", value, retval); return -ENODEV; } @@ -77,7 +77,7 @@ processor_get_pstate ( if (retval) pr_debug("Failed to get current freq with " - "error 0x%lx, idx 0x%x\n", retval, *value); + "error 0x%llx, idx 0x%x\n", retval, *value); return (int)retval; }
Fix warning with %lx / s64 mismatch: CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate': warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 's64' {aka 'long long int'} [-Wformat=] CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> CC: Viresh Kumar <viresh.kumar@linaro.org> CC: linux-pm@vger.kernel.org Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> --- drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)