| Message ID | 20210319155710.2793637-2-m.tretter@pengutronix.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: dp83867: Configure LED modes via device tree | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: davem@davemloft.net kuba@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 50 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Fri, 19 Mar 2021 16:57:09 +0100, Michael Tretter wrote: > The DP83867 supports four configurable LED pins. Describe the > multiplexing of functions to the LEDs via device tree. > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > --- > .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++++++++++++++++++ > include/dt-bindings/net/ti-dp83867.h | 16 +++++++++++++ > 2 files changed, 40 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml: properties:ti,dp83867-led-mode-names:items: 'anyOf' conditional failed, one must be fixed: {'anyOf': {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]}} is not of type 'array' {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]} is not of type 'array' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml: properties:ti,dp83867-led-mode-names:items: {'anyOf': {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]}} is not of type 'array' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml: properties:ti,dp83867-led-mode-names:items: 'oneOf' conditional failed, one must be fixed: {'anyOf': {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]}} is not of type 'array' {'items': [{'const': 'led-0'}, {'const': 'led-1'}, {'const': 'led-2'}, {'const': 'led-gpio'}]} is not of type 'array' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,dp83867.yaml: ignoring, error in schema: properties: ti,dp83867-led-mode-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/net/ti,dp83867.yaml See https://patchwork.ozlabs.org/patch/1455937 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml index 047d757e8d82..d09e1cf42462 100644 --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml @@ -106,6 +106,30 @@ properties: Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable values. + ti,dp83867-led-mode-names: + $ref: /schemas/types.yaml#/definitions/string-array + description: | + A list of led name strings sorted in the same order as the + ti,dp83867-led-modes property. + items: + anyOf: + items: + - const: led-0 + - const: led-1 + - const: led-2 + - const: led-gpio + maxItems: 4 + + ti,dp83867-led-modes: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: | + The DP83867 supports four configurable LED pins. Several functions can + be multiplexed onto the LEDs for different modes of operation. + + Must contain an entry for each entry in ti,dp83867-led-mode-names. + See dt-bindings/net/ti-dp83867.h for applicable values. + maxItems: 4 + required: - reg diff --git a/include/dt-bindings/net/ti-dp83867.h b/include/dt-bindings/net/ti-dp83867.h index 6fc4b445d3a1..fc3891f37fd1 100644 --- a/include/dt-bindings/net/ti-dp83867.h +++ b/include/dt-bindings/net/ti-dp83867.h @@ -50,4 +50,20 @@ #define DP83867_CLK_O_SEL_REF_CLK 0xC /* Special flag to indicate clock should be off */ #define DP83867_CLK_O_SEL_OFF 0xFFFFFFFF + +/* LED configuration */ +#define DP83867_LED_LINK_EST 0x0 +#define DP83867_LED_RX_TX_ACT 0x1 +#define DP83867_LED_TX_ACT 0x2 +#define DP83867_LED_RX_ACT 0x3 +#define DP83867_LED_COLLISION_DET 0x4 +#define DP83867_LED_1000_BT_LINK 0x5 +#define DP83867_LED_100_BT_LINK 0x6 +#define DP83867_LED_10_BT_LINK 0x7 +#define DP83867_LED_10_100_BT_LINK 0x8 +#define DP83867_LED_100_1000_BT_LINK 0x9 +#define DP83867_LED_FULL_DUPLEX 0xa +#define DP83867_LED_LINK_EST_RX_TX_ACT 0xb +#define DP83867_LED_RX_TX_ERR 0xd +#define DP83867_LED_RX_ERR 0xe #endif
The DP83867 supports four configurable LED pins. Describe the multiplexing of functions to the LEDs via device tree. Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> --- .../devicetree/bindings/net/ti,dp83867.yaml | 24 +++++++++++++++++++ include/dt-bindings/net/ti-dp83867.h | 16 +++++++++++++ 2 files changed, 40 insertions(+)