| Message ID | 20210318024851.49693-1-Jianlin.Lv@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9ef05281e5d01dffdf75a4ae5c1aee7cbd7aaa73 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: Remove insn_buf[] declaration in inner block | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 10 of 10 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 19 this patch: 19 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 19 this patch: 19 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 18 Mar 2021 10:48:51 +0800 you wrote: > Two insn_buf[16] variables are declared in the function, which act on > function scope and block scope respectively. > The statement in the inner blocks is redundant, so remove it. > > Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> > --- > kernel/bpf/verifier.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [bpf-next] bpf: Remove insn_buf[] declaration in inner block https://git.kernel.org/bpf/bpf-next/c/9ef05281e5d0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index f9096b049cd6..e26c5170c953 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -11899,7 +11899,6 @@ static int do_misc_fixups(struct bpf_verifier_env *env) insn->code == (BPF_ALU64 | BPF_SUB | BPF_X)) { const u8 code_add = BPF_ALU64 | BPF_ADD | BPF_X; const u8 code_sub = BPF_ALU64 | BPF_SUB | BPF_X; - struct bpf_insn insn_buf[16]; struct bpf_insn *patch = &insn_buf[0]; bool issrc, isneg; u32 off_reg;
Two insn_buf[16] variables are declared in the function, which act on function scope and block scope respectively. The statement in the inner blocks is redundant, so remove it. Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> --- kernel/bpf/verifier.c | 1 - 1 file changed, 1 deletion(-)