diff mbox series

crypto: atmel-ecc - fix W=1 "cannot understand" warning

Message ID 1616228113-15169-1-git-send-email-yumeng18@huawei.com (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show
Series crypto: atmel-ecc - fix W=1 "cannot understand" warning | expand

Commit Message

Meng Yu March 20, 2021, 8:15 a.m. UTC
Fix kernel-doc warnings due to missing "struct" keyword.

The warning likes:
drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '

Signed-off-by: Meng Yu <yumeng18@huawei.com>
---
 drivers/crypto/atmel-ecc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Randy Dunlap March 20, 2021, 4:17 p.m. UTC | #1
On Sat, 20 Mar 2021, Meng Yu wrote:

> Fix kernel-doc warnings due to missing "struct" keyword.
>
> The warning likes:
> drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '
>
> Signed-off-by: Meng Yu <yumeng18@huawei.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> drivers/crypto/atmel-ecc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 515946c..333fbef 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -26,7 +26,7 @@
> static struct atmel_ecc_driver_data driver_data;
>
> /**
> - * atmel_ecdh_ctx - transformation context
> + * struct atmel_ecdh_ctx - transformation context
>  * @client     : pointer to i2c client device
>  * @fallback   : used for unsupported curves or when user wants to use its own
>  *               private key.
> -- 
> 2.8.1
>
>
Tudor Ambarus March 22, 2021, 9:11 a.m. UTC | #2
On 3/20/21 10:15 AM, Meng Yu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Fix kernel-doc warnings due to missing "struct" keyword.
> 
> The warning likes:
> drivers/crypto/atmel-ecc.c:40: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '
> 
> Signed-off-by: Meng Yu <yumeng18@huawei.com>

Thanks. There is a patch similar to yours that was sent in advance:
https://patchwork.kernel.org/project/linux-crypto/patch/20210318124422.3200180-7-lee.jones@linaro.org/

> ---
>  drivers/crypto/atmel-ecc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index 515946c..333fbef 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -26,7 +26,7 @@
>  static struct atmel_ecc_driver_data driver_data;
> 
>  /**
> - * atmel_ecdh_ctx - transformation context
> + * struct atmel_ecdh_ctx - transformation context
>   * @client     : pointer to i2c client device
>   * @fallback   : used for unsupported curves or when user wants to use its own
>   *               private key.
> --
> 2.8.1
>
diff mbox series

Patch

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index 515946c..333fbef 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -26,7 +26,7 @@ 
 static struct atmel_ecc_driver_data driver_data;
 
 /**
- * atmel_ecdh_ctx - transformation context
+ * struct atmel_ecdh_ctx - transformation context
  * @client     : pointer to i2c client device
  * @fallback   : used for unsupported curves or when user wants to use its own
  *               private key.