| Message ID | 1616092624-31870-1-git-send-email-deesin@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [V1,1/1] soc: qcom: smp2p: Add enable_irq_wake to SMP2P IRQ | expand |
Quoting Deepak Kumar Singh (2021-03-18 11:37:04) > SMP2P interrupts are expected to wake the processor from suspend. > Use enable_irq_wake to mark it wakeup capable from suspend. > > Signed-off-by: Chris Lew <clew@codeaurora.org> > Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org> > --- > drivers/soc/qcom/smp2p.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index 2df4883..df47ee6 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -538,6 +538,7 @@ static int qcom_smp2p_probe(struct platform_device *pdev) > goto unwind_interfaces; > } > > + enable_irq_wake(irq); > Can this use device_init_wakeup() and dev_pm_set_wake_irq() instead? I think that will help us recognize that this irq woke up the CPU and allow userspace to indicate that it doesn't want to get this wakeup for some reason. > return 0; >
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index 2df4883..df47ee6 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -538,6 +538,7 @@ static int qcom_smp2p_probe(struct platform_device *pdev) goto unwind_interfaces; } + enable_irq_wake(irq); return 0;