| Message ID | 20210323131952.2835509-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Queued, archived |
| Headers | show |
| Series | ARM: mvebu: avoid clang -Wtautological-constant warning | expand |
On Tue, Mar 23, 2021 at 02:19:42PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Clang warns about the comparison when using a 32-bit phys_addr_t: > > drivers/bus/mvebu-mbus.c:621:17: error: result of comparison of constant 4294967296 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] > if (reg_start >= 0x100000000ULL) > > Add a cast to shut up the warning. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/bus/mvebu-mbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c > index dd9e7343a5e3..ea0424922de7 100644 > --- a/drivers/bus/mvebu-mbus.c > +++ b/drivers/bus/mvebu-mbus.c > @@ -618,7 +618,7 @@ mvebu_mbus_find_bridge_hole(uint64_t *start, uint64_t *end) > * This part of the memory is above 4 GB, so we don't > * care for the MBus bridge hole. > */ > - if (reg_start >= 0x100000000ULL) > + if ((u64)reg_start >= 0x100000000ULL) > continue; > > /* > -- > 2.29.2 >
From: Arnd Bergmann <arnd@arndb.de> On Tue, 23 Mar 2021 14:19:42 +0100, Arnd Bergmann wrote: > Clang warns about the comparison when using a 32-bit phys_addr_t: > > drivers/bus/mvebu-mbus.c:621:17: error: result of comparison of constant 4294967296 with expression of type 'phys_addr_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare] > if (reg_start >= 0x100000000ULL) > > Add a cast to shut up the warning. Applied to arm/fixes. [1/1] ARM: mvebu: avoid clang -Wtautological-constant warning commit: da03f523e83350caf2cf12f1169eca129efc445a Arnd
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c index dd9e7343a5e3..ea0424922de7 100644 --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -618,7 +618,7 @@ mvebu_mbus_find_bridge_hole(uint64_t *start, uint64_t *end) * This part of the memory is above 4 GB, so we don't * care for the MBus bridge hole. */ - if (reg_start >= 0x100000000ULL) + if ((u64)reg_start >= 0x100000000ULL) continue; /*