[RFC,02/11] drm/bridge: ti-sn65dsi86: Make enable GPIO optional

Commit Message

Laurent Pinchart March 22, 2021, 3:01 a.m. UTC

The enable signal may not be controllable by the kernel. Make it
optional.

Signed-off-by: Laurent Pinchart <[e-mail]>
---
 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jagan Teki March 22, 2021, 10:29 a.m. UTC | #1

On Mon, Mar 22, 2021 at 8:32 AM Laurent Pinchart
<[e-mail]> wrote:
>
> The enable signal may not be controllable by the kernel. Make it
> optional.
>
> Signed-off-by: Laurent Pinchart <[e-mail]>
> ---

Reviewed-by: Jagan Teki <[e-mail]>

Stephen Boyd March 23, 2021, 7:10 a.m. UTC | #2

Quoting Laurent Pinchart (2021-03-21 20:01:19)
> The enable signal may not be controllable by the kernel. Make it
> optional.
> 
> Signed-off-by: Laurent Pinchart <[e-mail]>
> ---

Reviewed-by: Stephen Boyd <[e-mail]>

Doug Anderson March 23, 2021, 9:08 p.m. UTC | #3

Hi,

On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart
<[e-mail]> wrote:
>
> The enable signal may not be controllable by the kernel. Make it
> optional.
>
> Signed-off-by: Laurent Pinchart <[e-mail]>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <[e-mail]>

Patch

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index f27306c51e4d..da78a12e58b5 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1245,8 +1245,8 @@  static int ti_sn_bridge_probe(struct i2c_client *client,
 
 	dev_set_drvdata(&client->dev, pdata);
 
-	pdata->enable_gpio = devm_gpiod_get(pdata->dev, "enable",
-					    GPIOD_OUT_LOW);
+	pdata->enable_gpio = devm_gpiod_get_optional(pdata->dev, "enable",
+						     GPIOD_OUT_LOW);
 	if (IS_ERR(pdata->enable_gpio)) {
 		DRM_ERROR("failed to get enable gpio from DT\n");
 		ret = PTR_ERR(pdata->enable_gpio);