| Message ID | 1616551405-41488-1-git-send-email-yumeng18@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] Bluetooth: SCO - Remove trailing semicolon in macros | expand |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=454281
---Test result---
##############################
Test: CheckPatch - FAIL
Bluetooth: SCO - Remove trailing semicolon in macros
CHECK: Macro argument 'c' may be better as '(c)' to avoid precedence issues
#20: FILE: net/bluetooth/sco.c:54:
+#define sco_conn_lock(c) spin_lock(&c->lock)
CHECK: Macro argument 'c' may be better as '(c)' to avoid precedence issues
#21: FILE: net/bluetooth/sco.c:55:
+#define sco_conn_unlock(c) spin_unlock(&c->lock)
total: 0 errors, 0 warnings, 2 checks, 10 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] Bluetooth: SCO - Remove trailing semicolon in macros" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuildK - PASS
##############################
Test: CheckTestRunner: Setup - PASS
##############################
Test: CheckTestRunner: l2cap-tester - PASS
Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6
##############################
Test: CheckTestRunner: bnep-tester - PASS
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: mgmt-tester - PASS
Total: 416, Passed: 400 (96.2%), Failed: 0, Not Run: 16
##############################
Test: CheckTestRunner: rfcomm-tester - PASS
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: sco-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: smp-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
##############################
Test: CheckTestRunner: userchan-tester - PASS
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0
---
Regards,
Linux Bluetooth
Hi Meng, > Macros should not use a trailing semicolon. > > Signed-off-by: Meng Yu <yumeng18@huawei.com> > --- > > Changes in v2 > -Modify comments > > net/bluetooth/sco.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c index 22a110f..3bd4156 100644 --- a/net/bluetooth/sco.c +++ b/net/bluetooth/sco.c @@ -51,8 +51,8 @@ struct sco_conn { unsigned int mtu; }; -#define sco_conn_lock(c) spin_lock(&c->lock); -#define sco_conn_unlock(c) spin_unlock(&c->lock); +#define sco_conn_lock(c) spin_lock(&c->lock) +#define sco_conn_unlock(c) spin_unlock(&c->lock) static void sco_sock_close(struct sock *sk); static void sco_sock_kill(struct sock *sk);
Macros should not use a trailing semicolon. Signed-off-by: Meng Yu <yumeng18@huawei.com> --- Changes in v2 -Modify comments net/bluetooth/sco.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)