| Message ID | 20210324150518.2734402-5-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vmalloc: Improve vmalloc(4MB) performance | expand |
On Wed, 24 Mar 2021, Matthew Wilcox (Oracle) wrote: > People should know to cc Vlad on vmalloc-related patches. With this, > get-maintainer.pl suggests: > > Uladzislau Rezki <urezki@gmail.com> (maintainer:VMALLOC) > Andrew Morton <akpm@linux-foundation.org> (maintainer:MEMORY MANAGEMENT) > linux-mm@kvack.org (open list:VMALLOC) > linux-kernel@vger.kernel.org (open list) > > which looks appropriate to me. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > MAINTAINERS | 7 +++++++ > arch/arm64/kernel/module.c | 3 +-- > arch/arm64/net/bpf_jit_comp.c | 3 +-- > arch/parisc/kernel/module.c | 5 ++--- > arch/x86/hyperv/hv_init.c | 3 +-- > 5 files changed, 12 insertions(+), 9 deletions(-) Looks like we got some extra cleanups with this :) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8c44fd8fd85d..8b9cb5525cb1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19282,6 +19282,13 @@ S: Maintained > F: drivers/vlynq/vlynq.c > F: include/linux/vlynq.h > > +VMALLOC > +M: Uladzislau Rezki <urezki@gmail.com> Should be 'M' or 'R'? (Not sure if Vlad will be pushing patches or not.) > +L: linux-mm@kvack.org > +S: Maintained > +F: mm/vmalloc.c > +F: include/linux/vmalloc.h > + > VME SUBSYSTEM > M: Martyn Welch <martyn@welchs.me.uk> > M: Manohar Vanga <manohar.vanga@gmail.com> > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > index fa4186459927..5e31bc901631 100644 > --- a/arch/arm64/kernel/module.c > +++ b/arch/arm64/kernel/module.c > @@ -53,8 +53,7 @@ void *module_alloc(unsigned long size) > */ > p = __vmalloc_node_range(size, MODULE_ALIGN, module_alloc_base, > module_alloc_base + SZ_2G, GFP_KERNEL, > - PAGE_KERNEL, 0, NUMA_NO_NODE, > - _RET_IP_); > + PAGE_KERNEL, 0, NUMA_NO_NODE, _RET_IP_); > > if (p && (kasan_module_alloc(p, size) < 0)) { > vfree(p); > diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c > index 8aca5bf74685..f3a6c1b49c4e 100644 > --- a/arch/arm64/net/bpf_jit_comp.c > +++ b/arch/arm64/net/bpf_jit_comp.c > @@ -1133,8 +1133,7 @@ void *bpf_jit_alloc_exec(unsigned long size) > { > return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START, > BPF_JIT_REGION_END, GFP_KERNEL, > - PAGE_KERNEL, 0, NUMA_NO_NODE, > - _RET_IP_); > + PAGE_KERNEL, 0, NUMA_NO_NODE, _RET_IP_); > } > > void bpf_jit_free_exec(void *addr) > diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c > index 320807f755a7..7181c4f99059 100644 > --- a/arch/parisc/kernel/module.c > +++ b/arch/parisc/kernel/module.c > @@ -198,9 +198,8 @@ void *module_alloc(unsigned long size) > * easier than trying to map the text, data, init_text and > * init_data correctly */ > return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, > - GFP_KERNEL, > - PAGE_KERNEL_RWX, 0, NUMA_NO_NODE, > - _RET_IP_); > + GFP_KERNEL, PAGE_KERNEL_RWX, 0, > + NUMA_NO_NODE, _RET_IP_); > } > > #ifndef CONFIG_64BIT > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index 4866351282b0..a256a955d05f 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/hyperv/hv_init.c > @@ -427,8 +427,7 @@ void __init hyperv_init(void) > > hv_hypercall_pg = __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, > VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_ROX, > - VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, > - _RET_IP_); > + VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, _RET_IP_); > if (hv_hypercall_pg == NULL) { > wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); > goto remove_cpuhp_state; > -- > 2.30.2 > > >
On Wed, Mar 24, 2021 at 11:52:37AM -0700, David Rientjes wrote: > > MAINTAINERS | 7 +++++++ > > arch/arm64/kernel/module.c | 3 +-- > > arch/arm64/net/bpf_jit_comp.c | 3 +-- > > arch/parisc/kernel/module.c | 5 ++--- > > arch/x86/hyperv/hv_init.c | 3 +-- > > 5 files changed, 12 insertions(+), 9 deletions(-) > > Looks like we got some extra cleanups with this :) Oops, those should have been squashed into 1/4. I'll do a v3 later this week. > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 8c44fd8fd85d..8b9cb5525cb1 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19282,6 +19282,13 @@ S: Maintained > > F: drivers/vlynq/vlynq.c > > F: include/linux/vlynq.h > > > > +VMALLOC > > +M: Uladzislau Rezki <urezki@gmail.com> > > Should be 'M' or 'R'? (Not sure if Vlad will be pushing patches or not.) Well, you & others are listed as M: for SLAB so I just copied what was there. I don't know what's best practice these days, but I think they should match? > > +L: linux-mm@kvack.org > > +S: Maintained > > +F: mm/vmalloc.c > > +F: include/linux/vmalloc.h
diff --git a/MAINTAINERS b/MAINTAINERS index 8c44fd8fd85d..8b9cb5525cb1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19282,6 +19282,13 @@ S: Maintained F: drivers/vlynq/vlynq.c F: include/linux/vlynq.h +VMALLOC +M: Uladzislau Rezki <urezki@gmail.com> +L: linux-mm@kvack.org +S: Maintained +F: mm/vmalloc.c +F: include/linux/vmalloc.h + VME SUBSYSTEM M: Martyn Welch <martyn@welchs.me.uk> M: Manohar Vanga <manohar.vanga@gmail.com> diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c index fa4186459927..5e31bc901631 100644 --- a/arch/arm64/kernel/module.c +++ b/arch/arm64/kernel/module.c @@ -53,8 +53,7 @@ void *module_alloc(unsigned long size) */ p = __vmalloc_node_range(size, MODULE_ALIGN, module_alloc_base, module_alloc_base + SZ_2G, GFP_KERNEL, - PAGE_KERNEL, 0, NUMA_NO_NODE, - _RET_IP_); + PAGE_KERNEL, 0, NUMA_NO_NODE, _RET_IP_); if (p && (kasan_module_alloc(p, size) < 0)) { vfree(p); diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c index 8aca5bf74685..f3a6c1b49c4e 100644 --- a/arch/arm64/net/bpf_jit_comp.c +++ b/arch/arm64/net/bpf_jit_comp.c @@ -1133,8 +1133,7 @@ void *bpf_jit_alloc_exec(unsigned long size) { return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START, BPF_JIT_REGION_END, GFP_KERNEL, - PAGE_KERNEL, 0, NUMA_NO_NODE, - _RET_IP_); + PAGE_KERNEL, 0, NUMA_NO_NODE, _RET_IP_); } void bpf_jit_free_exec(void *addr) diff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c index 320807f755a7..7181c4f99059 100644 --- a/arch/parisc/kernel/module.c +++ b/arch/parisc/kernel/module.c @@ -198,9 +198,8 @@ void *module_alloc(unsigned long size) * easier than trying to map the text, data, init_text and * init_data correctly */ return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, - GFP_KERNEL, - PAGE_KERNEL_RWX, 0, NUMA_NO_NODE, - _RET_IP_); + GFP_KERNEL, PAGE_KERNEL_RWX, 0, + NUMA_NO_NODE, _RET_IP_); } #ifndef CONFIG_64BIT diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index 4866351282b0..a256a955d05f 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -427,8 +427,7 @@ void __init hyperv_init(void) hv_hypercall_pg = __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_ROX, - VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, - _RET_IP_); + VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, _RET_IP_); if (hv_hypercall_pg == NULL) { wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); goto remove_cpuhp_state;
People should know to cc Vlad on vmalloc-related patches. With this, get-maintainer.pl suggests: Uladzislau Rezki <urezki@gmail.com> (maintainer:VMALLOC) Andrew Morton <akpm@linux-foundation.org> (maintainer:MEMORY MANAGEMENT) linux-mm@kvack.org (open list:VMALLOC) linux-kernel@vger.kernel.org (open list) which looks appropriate to me. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- MAINTAINERS | 7 +++++++ arch/arm64/kernel/module.c | 3 +-- arch/arm64/net/bpf_jit_comp.c | 3 +-- arch/parisc/kernel/module.c | 5 ++--- arch/x86/hyperv/hv_init.c | 3 +-- 5 files changed, 12 insertions(+), 9 deletions(-)