| Message ID | 20210324175438.680310-2-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE | expand |
On 3/24/21 11:54 AM, Philippe Mathieu-Daudé wrote: > Named IRQs are easier to understand in the monitor. > Name the single output interrupt as 'intr'. > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > hw/isa/vt82c686.c | 2 +- > hw/mips/fuloong2e.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 05d084f6982..87473ec121f 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -387,7 +387,7 @@ static void vt82c686b_realize(PCIDevice *d, Error **errp) qemu_irq *isa_irq; int i; - qdev_init_gpio_out(dev, &s->cpu_intr, 1); + qdev_init_gpio_out_named(dev, &s->cpu_intr, "intr", 1); isa_irq = qemu_allocate_irqs(via_isa_request_i8259_irq, s, 1); isa_bus = isa_bus_new(dev, get_system_memory(), pci_address_space_io(d), &error_fatal); diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index 4f61f2c873b..931385c760f 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -206,7 +206,7 @@ static void vt82c686b_southbridge_init(PCIBus *pci_bus, int slot, qemu_irq intc, dev = pci_create_simple_multifunction(pci_bus, PCI_DEVFN(slot, 0), true, TYPE_VT82C686B_ISA); - qdev_connect_gpio_out(DEVICE(dev), 0, intc); + qdev_connect_gpio_out_named(DEVICE(dev), "intr", 0, intc); dev = pci_create_simple(pci_bus, PCI_DEVFN(slot, 1), "via-ide"); pci_ide_create_devs(dev);
Named IRQs are easier to understand in the monitor. Name the single output interrupt as 'intr'. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/isa/vt82c686.c | 2 +- hw/mips/fuloong2e.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)