Message ID | 20210325060356.4040114-18-jsnow@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | qapi: static typing conversion, pt3 | expand |
John Snow <jsnow@redhat.com> writes: > It is -- maybe -- possibly -- three nanoseconds faster. > > Signed-off-by: John Snow <jsnow@redhat.com> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> > Reviewed-by: Cleber Rosa <crosa@redhat.com> > > --- > > This can be dropped if desired; it has no real functional impact I could > defend in code review court. I just happened to write it this way. I'm fine with taking this. Could it go right after PATCH 11? If not, no big deal.
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index adc5b903bc..b11c11b965 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.py @@ -210,11 +210,11 @@ def check_flags(expr: _JSONObject, info: QAPISourceInfo) -> None: :param expr: Expression to validate. :param info: QAPI source file information. """ - for key in ['gen', 'success-response']: + for key in ('gen', 'success-response'): if key in expr and expr[key] is not False: raise QAPISemError( info, "flag '%s' may only use false value" % key) - for key in ['boxed', 'allow-oob', 'allow-preconfig', 'coroutine']: + for key in ('boxed', 'allow-oob', 'allow-preconfig', 'coroutine'): if key in expr and expr[key] is not True: raise QAPISemError( info, "flag '%s' may only use true value" % key)