| Message ID | 46f6e3cb-cc96-d214-e183-71dd238da075@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tomoyo: don't special case PF_IO_WORKER for PF_KTHREAD | expand |
On 3/25/2021 5:44 PM, Jens Axboe wrote: > The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no > need to special case them for credential checks. Could you cite the commit where that change was made? > > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Signed-off-by: Jens Axboe <axboe@kernel.dk> > --- > security/tomoyo/network.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/tomoyo/network.c b/security/tomoyo/network.c > index 478f757ff843..8dc61335f65e 100644 > --- a/security/tomoyo/network.c > +++ b/security/tomoyo/network.c > @@ -613,7 +613,7 @@ static int tomoyo_check_unix_address(struct sockaddr *addr, > static bool tomoyo_kernel_service(void) > { > /* Nothing to do if I am a kernel service. */ > - return (current->flags & (PF_KTHREAD | PF_IO_WORKER)) == PF_KTHREAD; > + return current->flags & PF_KTHREAD; > } > > /**
On 3/26/21 10:03 AM, Casey Schaufler wrote: > On 3/25/2021 5:44 PM, Jens Axboe wrote: >> The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no >> need to special case them for credential checks. > > Could you cite the commit where that change was made? See previous reply, same one: commit 3bfe6106693b6b4ba175ad1f929c4660b8f59ca8 Author: Jens Axboe <axboe@kernel.dk> Date: Tue Feb 16 14:15:30 2021 -0700 io-wq: fork worker threads from original task
diff --git a/security/tomoyo/network.c b/security/tomoyo/network.c index 478f757ff843..8dc61335f65e 100644 --- a/security/tomoyo/network.c +++ b/security/tomoyo/network.c @@ -613,7 +613,7 @@ static int tomoyo_check_unix_address(struct sockaddr *addr, static bool tomoyo_kernel_service(void) { /* Nothing to do if I am a kernel service. */ - return (current->flags & (PF_KTHREAD | PF_IO_WORKER)) == PF_KTHREAD; + return current->flags & PF_KTHREAD; } /**
The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no need to special case them for credential checks. Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Jens Axboe <axboe@kernel.dk> --- security/tomoyo/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)