Message ID | cover.1616779714.git.lukasstraub2@web.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/cover.1616779714.git.lukasstraub2@web.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1616779714.git.lukasstraub2@web.de Subject: [PULL for 6.0 0/6] Yank fixes === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/cover.1616744509.git.lukasstraub2@web.de -> patchew/cover.1616744509.git.lukasstraub2@web.de * [new tag] patchew/cover.1616779714.git.lukasstraub2@web.de -> patchew/cover.1616779714.git.lukasstraub2@web.de Switched to a new branch 'test' 4d9d4dd tests: Add tests for yank with the chardev-change case b7309a3 chardev: Fix yank with the chardev-change case 4d626de chardev/char.c: Always pass id to chardev_new 986704e chardev/char.c: Move object_property_try_add_child out of chardev_new 3a83f9a yank: Always link full yank code 4142c6d yank: Remove dependency on qiochannel === OUTPUT BEGIN === 1/6 Checking commit 4142c6de8bf2 (yank: Remove dependency on qiochannel) 2/6 Checking commit 3a83f9a8f30f (yank: Always link full yank code) 3/6 Checking commit 986704eacfdf (chardev/char.c: Move object_property_try_add_child out of chardev_new) 4/6 Checking commit 4d626de1c86e (chardev/char.c: Always pass id to chardev_new) 5/6 Checking commit b7309a3515a2 (chardev: Fix yank with the chardev-change case) 6/6 Checking commit 4d9d4dda05e4 (tests: Add tests for yank with the chardev-change case) ERROR: Macros with multiple statements should be enclosed in a do - while loop #230: FILE: tests/unit/test-yank.c:180: +#define CHAR_CHANGE_TEST(name, _old_yank, _new_yank) \ + g_test_add_data_func("/yank/char_change/success/" # name, \ + &(CharChangeTestConfig) { .addr = &tcpaddr, \ + .old_yank = (_old_yank),\ + .new_yank = (_new_yank),\ + .fail = false }, \ + char_change_test); \ + g_test_add_data_func("/yank/char_change/fail/" # name, \ + &(CharChangeTestConfig) { .addr = &tcpaddr, \ + .old_yank = (_old_yank),\ + .new_yank = (_new_yank),\ + .fail = true }, \ + char_change_test); total: 1 errors, 0 warnings, 216 lines checked Patch 6/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/cover.1616779714.git.lukasstraub2@web.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 26 Mar 2021 at 17:34, Lukas Straub <lukasstraub2@web.de> wrote: > > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: > > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into staging (2021-03-22 18:50:25 +0000) > > are available in the Git repository at: > > https://github.com/Lukey3332/qemu.git tags/pull-26-03-2021 > > for you to fetch changes up to 7c2f1ddcaa1c97462cb0b834d5aa7368283aa67d: > > tests: Add tests for yank with the chardev-change case (2021-03-26 17:12:18 +0000) > > ---------------------------------------------------------------- > Yank fixes for 6.0: > -Remove qiochannel dependency from the yank core code > -Always link in the yank code to increase test coverage > -Fix yank with chardev-change > -Add tests for yank with chardev-change Can we get these through some established submaintainer tree, please? thanks -- PMM
On Fri, 26 Mar 2021 17:52:40 +0000 Peter Maydell <peter.maydell@linaro.org> wrote: > On Fri, 26 Mar 2021 at 17:34, Lukas Straub <lukasstraub2@web.de> wrote: > > > > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: > > > > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into staging (2021-03-22 18:50:25 +0000) > > > > are available in the Git repository at: > > > > https://github.com/Lukey3332/qemu.git tags/pull-26-03-2021 > > > > for you to fetch changes up to 7c2f1ddcaa1c97462cb0b834d5aa7368283aa67d: > > > > tests: Add tests for yank with the chardev-change case (2021-03-26 17:12:18 +0000) > > > > ---------------------------------------------------------------- > > Yank fixes for 6.0: > > -Remove qiochannel dependency from the yank core code > > -Always link in the yank code to increase test coverage > > -Fix yank with chardev-change > > -Add tests for yank with chardev-change > > Can we get these through some established submaintainer tree, please? > > thanks > -- PMM I guess Marc-André Lureau or Markus Armbruster can take it trough their tree. Regards, Lukas Straub --
Lukas Straub <lukasstraub2@web.de> writes: > On Fri, 26 Mar 2021 17:52:40 +0000 > Peter Maydell <peter.maydell@linaro.org> wrote: > >> On Fri, 26 Mar 2021 at 17:34, Lukas Straub <lukasstraub2@web.de> wrote: >> > >> > The following changes since commit 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: >> > >> > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' into staging (2021-03-22 18:50:25 +0000) >> > >> > are available in the Git repository at: >> > >> > https://github.com/Lukey3332/qemu.git tags/pull-26-03-2021 >> > >> > for you to fetch changes up to 7c2f1ddcaa1c97462cb0b834d5aa7368283aa67d: >> > >> > tests: Add tests for yank with the chardev-change case (2021-03-26 17:12:18 +0000) >> > >> > ---------------------------------------------------------------- >> > Yank fixes for 6.0: >> > -Remove qiochannel dependency from the yank core code >> > -Always link in the yank code to increase test coverage >> > -Fix yank with chardev-change >> > -Add tests for yank with chardev-change >> >> Can we get these through some established submaintainer tree, please? >> >> thanks >> -- PMM > > I guess Marc-André Lureau or Markus Armbruster can take it trough their tree. My Easter break starts basically now. Marc-André, could you take care of it? Alternatively, perhaps Eric?
Hi On Sat, Mar 27, 2021 at 12:56 AM Markus Armbruster <armbru@redhat.com> wrote: > Lukas Straub <lukasstraub2@web.de> writes: > > > On Fri, 26 Mar 2021 17:52:40 +0000 > > Peter Maydell <peter.maydell@linaro.org> wrote: > > > >> On Fri, 26 Mar 2021 at 17:34, Lukas Straub <lukasstraub2@web.de> wrote: > >> > > >> > The following changes since commit > 5ca634afcf83215a9a54ca6e66032325b5ffb5f6: > >> > > >> > Merge remote-tracking branch 'remotes/philmd/tags/sdmmc-20210322' > into staging (2021-03-22 18:50:25 +0000) > >> > > >> > are available in the Git repository at: > >> > > >> > https://github.com/Lukey3332/qemu.git tags/pull-26-03-2021 > >> > > >> > for you to fetch changes up to > 7c2f1ddcaa1c97462cb0b834d5aa7368283aa67d: > >> > > >> > tests: Add tests for yank with the chardev-change case (2021-03-26 > 17:12:18 +0000) > >> > > >> > ---------------------------------------------------------------- > >> > Yank fixes for 6.0: > >> > -Remove qiochannel dependency from the yank core code > >> > -Always link in the yank code to increase test coverage > >> > -Fix yank with chardev-change > >> > -Add tests for yank with chardev-change > >> > >> Can we get these through some established submaintainer tree, please? > >> > >> thanks > >> -- PMM > > > > I guess Marc-André Lureau or Markus Armbruster can take it trough their > tree. > > My Easter break starts basically now. Marc-André, could you take care > of it? Alternatively, perhaps Eric? > > Yes, I will send a PR Enjoy!