| Message ID | 20210326175809.2923789-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | phy: qcom-qmp: provide DP phy support for sm8250 | expand |
On Fri, 26 Mar 2021 20:58:03 +0300, Dmitry Baryshkov wrote: > The commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy > information") has support for DP part of USB3+DP combo PHYs. However > this change is not backwards compatible, placing additional requirements > onto qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy device nodes > (to include separate DP part, etc). However the aforementioned nodes do > not inclue DP part, they strictly follow the schema defined in the > qcom,qmp-phy.yaml file. Move those compatibles, leaving > qcom,qmp-usb3-dp-phy.yaml to describe only real "combo" USB3+DP device nodes. > > Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information") > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Sandeep Maheswaram <sanm@codeaurora.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++ > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Quoting Dmitry Baryshkov (2021-03-26 10:58:03) > The commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy > information") has support for DP part of USB3+DP combo PHYs. However > this change is not backwards compatible, placing additional requirements > onto qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy device nodes > (to include separate DP part, etc). However the aforementioned nodes do > not inclue DP part, they strictly follow the schema defined in the > qcom,qmp-phy.yaml file. Move those compatibles, leaving > qcom,qmp-usb3-dp-phy.yaml to describe only real "combo" USB3+DP device nodes. > > Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information") > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Sandeep Maheswaram <sanm@codeaurora.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++ > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index 626447fee092..0f42b36b0ac5 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -25,11 +25,13 @@ properties: > - qcom,msm8998-qmp-pcie-phy > - qcom,msm8998-qmp-ufs-phy > - qcom,msm8998-qmp-usb3-phy > + - qcom,sc7180x-qmp-usb3-phy Drop the x on sc7180? > - qcom,sc8180x-qmp-ufs-phy > - qcom,sc8180x-qmp-usb3-phy > - qcom,sdm845-qhp-pcie-phy > - qcom,sdm845-qmp-pcie-phy > - qcom,sdm845-qmp-ufs-phy > + - qcom,sdm845-qmp-usb3-phy > - qcom,sdm845-qmp-usb3-uni-phy > - qcom,sm8150-qmp-ufs-phy > - qcom,sm8150-qmp-usb3-phy Otherwise Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 626447fee092..0f42b36b0ac5 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -25,11 +25,13 @@ properties: - qcom,msm8998-qmp-pcie-phy - qcom,msm8998-qmp-ufs-phy - qcom,msm8998-qmp-usb3-phy + - qcom,sc7180x-qmp-usb3-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8180x-qmp-usb3-phy - qcom,sdm845-qhp-pcie-phy - qcom,sdm845-qmp-pcie-phy - qcom,sdm845-qmp-ufs-phy + - qcom,sdm845-qmp-usb3-phy - qcom,sdm845-qmp-usb3-uni-phy - qcom,sm8150-qmp-ufs-phy - qcom,sm8150-qmp-usb3-phy diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml index 33974ad10afe..62c0179d1765 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml @@ -14,9 +14,7 @@ properties: compatible: enum: - qcom,sc7180-qmp-usb3-dp-phy - - qcom,sc7180-qmp-usb3-phy - qcom,sdm845-qmp-usb3-dp-phy - - qcom,sdm845-qmp-usb3-phy reg: items: - description: Address and length of PHY's USB serdes block.
The commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information") has support for DP part of USB3+DP combo PHYs. However this change is not backwards compatible, placing additional requirements onto qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy device nodes (to include separate DP part, etc). However the aforementioned nodes do not inclue DP part, they strictly follow the schema defined in the qcom,qmp-phy.yaml file. Move those compatibles, leaving qcom,qmp-usb3-dp-phy.yaml to describe only real "combo" USB3+DP device nodes. Fixes: 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information") Cc: Stephen Boyd <swboyd@chromium.org> Cc: Sandeep Maheswaram <sanm@codeaurora.org> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++ Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)