| Message ID | 20210326194348.623782-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 235fc0e36d35270e1ff426f26bbea6154b8863a5 |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf: remove redundant assignment of variable id | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Fri, Mar 26, 2021 at 12:45 PM Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > The variable id is being assigned a value that is never > read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Song Liu <songliubraving@fb.com> For future patches, please prefix it as [PATCH bpf-next] for [PATCH bpf], based on which tree the patch should apply to. > --- > kernel/bpf/btf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c > index 369faeddf1df..b22fb29347c0 100644 > --- a/kernel/bpf/btf.c > +++ b/kernel/bpf/btf.c > @@ -789,7 +789,6 @@ static const struct btf_type *btf_type_skip_qualifiers(const struct btf *btf, > > while (btf_type_is_modifier(t) && > BTF_INFO_KIND(t->info) != BTF_KIND_TYPEDEF) { > - id = t->type; > t = btf_type_by_id(btf, t->type); > } > > -- > 2.30.2 >
On Fri, Mar 26, 2021 at 01:18:36PM -0700, Song Liu wrote: > On Fri, Mar 26, 2021 at 12:45 PM Colin King <colin.king@canonical.com> wrote: > > > > From: Colin Ian King <colin.king@canonical.com> > > > > The variable id is being assigned a value that is never > > read, the assignment is redundant and can be removed. > > > > Addresses-Coverity: ("Unused value") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Acked-by: Song Liu <songliubraving@fb.com> > > For future patches, please prefix it as [PATCH bpf-next] for > [PATCH bpf], based on which tree the patch should apply to. > You can keep asking us to do that but it's never going to happen... :P I do this for networking but it's a massive pain in the butt and I get it wrong 20% of the time. regards, dan carpenter
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 26 Mar 2021 19:43:48 +0000 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable id is being assigned a value that is never > read, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is the summary with links: - bpf: remove redundant assignment of variable id https://git.kernel.org/bpf/bpf-next/c/235fc0e36d35 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 369faeddf1df..b22fb29347c0 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -789,7 +789,6 @@ static const struct btf_type *btf_type_skip_qualifiers(const struct btf *btf, while (btf_type_is_modifier(t) && BTF_INFO_KIND(t->info) != BTF_KIND_TYPEDEF) { - id = t->type; t = btf_type_by_id(btf, t->type); }