| Message ID | 20210329130103.65857-1-s.riedmueller@phytec.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing | expand |
Hi Stefan, On Mon, Mar 29, 2021 at 10:01 AM Stefan Riedmueller <s.riedmueller@phytec.de> wrote: > > The pinmuxing for the enable pin of the usbh1 node is wrong. It needs to > be muxed as GPIO. While at it, move the pinctrl to the vbus regulator > since it is actually the regulator enable pin. > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> Thanks for the respin: Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Mon, Mar 29, 2021 at 03:01:01PM +0200, Stefan Riedmueller wrote: > The pinmuxing for the enable pin of the usbh1 node is wrong. It needs to > be muxed as GPIO. While at it, move the pinctrl to the vbus regulator > since it is actually the regulator enable pin. > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> Applied all, thanks.
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi index 7a1e53195785..9f39c926cc08 100644 --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi @@ -31,6 +31,8 @@ reg_usb_otg_vbus: regulator@0 { reg_usb_h1_vbus: regulator@1 { compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbh1_vbus>; reg = <1>; regulator-name = "usb_h1_vbus"; regulator-min-microvolt = <5000000>; @@ -328,9 +330,9 @@ MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA 0x1b0b1 >; }; - pinctrl_usbh1: usbh1grp { + pinctrl_usbh1_vbus: usbh1vbusgrp { fsl,pins = < - MX6QDL_PAD_GPIO_0__USB_H1_PWR 0x80000000 + MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0 >; }; @@ -415,8 +417,6 @@ &uart4 { &usbh1 { vbus-supply = <®_usb_h1_vbus>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbh1>; status = "disabled"; };
The pinmuxing for the enable pin of the usbh1 node is wrong. It needs to be muxed as GPIO. While at it, move the pinctrl to the vbus regulator since it is actually the regulator enable pin. Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> --- Changes in v2: - Use default pad ctl value instead of 0x80000000 arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)