| Message ID | 20210329161256.31171-3-christianshewitt@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: meson: misc ODROID-N2/N2+ changes | expand |
Hi, On 29/03/2021 18:12, Christian Hewitt wrote: > From: Hyeonki Hong <hhk7734@gmail.com> > > Add the meson saradc node to the ODROID N2/N2+ common dtsi. Not sure why this is needed, does it fix something ? Neil > > Signed-off-by: Hyeonki Hong <hhk7734@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > index 2f8d574c30c0..139c12cf9f66 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > @@ -508,6 +508,10 @@ > status = "okay"; > }; > > +&saradc { > + status = "okay"; > +}; > + > /* SD card */ > &sd_emmc_b { > status = "okay"; >
On Tue, Mar 30, 2021 at 1:18 AM Christian Hewitt <christianshewitt@gmail.com> wrote: > > From: Hyeonki Hong <hhk7734@gmail.com> > > Add the meson saradc node to the ODROID N2/N2+ common dtsi. in general I am fine with this as some SAR ADC channels seem to be on the pin headers... [...] > +&saradc { > + status = "okay"; > +}; ...but a vref-supply should be provided to get meaningful numbers
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi index 2f8d574c30c0..139c12cf9f66 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi @@ -508,6 +508,10 @@ status = "okay"; }; +&saradc { + status = "okay"; +}; + /* SD card */ &sd_emmc_b { status = "okay";