| Message ID | 20210330210613.2765853-1-eric.dumazet@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8128656a5edd23a91542c9da849cd878a54148d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: fix icmp_echo_enable_probe sysctl | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: yoshfuji@linux-ipv6.org dsahern@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 1 this patch: 1 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1 this patch: 1 |
| netdev/header_inline | success | Link |
On Tue, Mar 30, 2021 at 11:06 PM Eric Dumazet <eric.dumazet@gmail.com> wrote: > > From: Eric Dumazet <edumazet@google.com> > > sysctl_icmp_echo_enable_probe is an u8. > > ipv4_net_table entry should use > .maxlen = sizeof(u8). > .proc_handler = proc_dou8vec_minmax, > I should have added the following tag : Fixes: f1b8fa9fa586 ("net: add sysctl for enabling RFC 8335 PROBE messages") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Andreas Roeseler <andreas.a.roeseler@gmail.com> > --- > net/ipv4/sysctl_net_ipv4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c > index e3cb2d96b55e99f4322a99abb6a6da866dffcf4d..9199f507a005efc3f57ca0225d3898bfa5d01c53 100644 > --- a/net/ipv4/sysctl_net_ipv4.c > +++ b/net/ipv4/sysctl_net_ipv4.c > @@ -601,9 +601,9 @@ static struct ctl_table ipv4_net_table[] = { > { > .procname = "icmp_echo_enable_probe", > .data = &init_net.ipv4.sysctl_icmp_echo_enable_probe, > - .maxlen = sizeof(int), > + .maxlen = sizeof(u8), > .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > + .proc_handler = proc_dou8vec_minmax, > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE > }, > -- > 2.31.0.291.g576ba9dcdaf-goog >
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 30 Mar 2021 14:06:13 -0700 you wrote: > From: Eric Dumazet <edumazet@google.com> > > sysctl_icmp_echo_enable_probe is an u8. > > ipv4_net_table entry should use > .maxlen = sizeof(u8). > .proc_handler = proc_dou8vec_minmax, > > [...] Here is the summary with links: - [net-next] net: fix icmp_echo_enable_probe sysctl https://git.kernel.org/netdev/net-next/c/b8128656a5ed You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c index e3cb2d96b55e99f4322a99abb6a6da866dffcf4d..9199f507a005efc3f57ca0225d3898bfa5d01c53 100644 --- a/net/ipv4/sysctl_net_ipv4.c +++ b/net/ipv4/sysctl_net_ipv4.c @@ -601,9 +601,9 @@ static struct ctl_table ipv4_net_table[] = { { .procname = "icmp_echo_enable_probe", .data = &init_net.ipv4.sysctl_icmp_echo_enable_probe, - .maxlen = sizeof(int), + .maxlen = sizeof(u8), .mode = 0644, - .proc_handler = proc_dointvec_minmax, + .proc_handler = proc_dou8vec_minmax, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE },