mbox series

[v1,0/7] MHI Emergency download and flash programmer support

Message ID 1617067704-28850-1-git-send-email-bbhatt@codeaurora.org (mailing list archive)
Headers show
Series MHI Emergency download and flash programmer support | expand

Message

Bhaumik Bhatt March 30, 2021, 1:28 a.m. UTC
Allow handling EDL mode after SYS_ERROR occurs by reading the execution
environment post handling and move to power on reset state to accommodate the
scenario.
Handle EDL mode properly and wait for ready instead of just exiting from the
firmware load.
Allow use of the Flash Programmer execution environment as a mission mode
use case for a blank NAND power up scenario.
Always attempt a wait for MHI ready state as device could be waiting for the
host to do so after pass through execution environment is seen.
Introduce patch to improve state awareness and aid in debugging.

This patch series was tested on x86_64 architecture.

Bhaumik Bhatt (6):
  bus: mhi: core: Rely on accurate method to determine EDL mode
  bus: mhi: core: Wait for ready after an EDL firmware download
  bus: mhi: core: Handle EDL mode entry appropriately
  bus: mhi: core: Identify Flash Programmer as a mission mode use case
  bus: mhi: core: Wait for MHI READY state in most scenarios
  bus: mhi: core: Improve state strings for debug messages

Carl Yin (1):
  bus: mhi: core: Add support for Flash Programmer execution environment

 drivers/bus/mhi/core/boot.c     | 13 +++++++------
 drivers/bus/mhi/core/init.c     | 34 ++++++++++++++++++----------------
 drivers/bus/mhi/core/internal.h |  4 +++-
 drivers/bus/mhi/core/main.c     |  3 +++
 drivers/bus/mhi/core/pm.c       | 28 +++++++++++++++++++++++++---
 include/linux/mhi.h             |  4 +++-
 6 files changed, 59 insertions(+), 27 deletions(-)

Comments

Manivannan Sadhasivam March 31, 2021, 11:16 a.m. UTC | #1
On Mon, Mar 29, 2021 at 06:28:17PM -0700, Bhaumik Bhatt wrote:
> Allow handling EDL mode after SYS_ERROR occurs by reading the execution
> environment post handling and move to power on reset state to accommodate the
> scenario.
> Handle EDL mode properly and wait for ready instead of just exiting from the
> firmware load.
> Allow use of the Flash Programmer execution environment as a mission mode
> use case for a blank NAND power up scenario.
> Always attempt a wait for MHI ready state as device could be waiting for the
> host to do so after pass through execution environment is seen.
> Introduce patch to improve state awareness and aid in debugging.
> 
> This patch series was tested on x86_64 architecture.
> 

These patches were part of a different series before. It is good that
you splitted the patches but you should mention that here.

Thanks,
Mani

> Bhaumik Bhatt (6):
>   bus: mhi: core: Rely on accurate method to determine EDL mode
>   bus: mhi: core: Wait for ready after an EDL firmware download
>   bus: mhi: core: Handle EDL mode entry appropriately
>   bus: mhi: core: Identify Flash Programmer as a mission mode use case
>   bus: mhi: core: Wait for MHI READY state in most scenarios
>   bus: mhi: core: Improve state strings for debug messages
> 
> Carl Yin (1):
>   bus: mhi: core: Add support for Flash Programmer execution environment
> 
>  drivers/bus/mhi/core/boot.c     | 13 +++++++------
>  drivers/bus/mhi/core/init.c     | 34 ++++++++++++++++++----------------
>  drivers/bus/mhi/core/internal.h |  4 +++-
>  drivers/bus/mhi/core/main.c     |  3 +++
>  drivers/bus/mhi/core/pm.c       | 28 +++++++++++++++++++++++++---
>  include/linux/mhi.h             |  4 +++-
>  6 files changed, 59 insertions(+), 27 deletions(-)
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Manivannan Sadhasivam March 31, 2021, 11:24 a.m. UTC | #2
On Mon, Mar 29, 2021 at 06:28:17PM -0700, Bhaumik Bhatt wrote:
> Allow handling EDL mode after SYS_ERROR occurs by reading the execution
> environment post handling and move to power on reset state to accommodate the
> scenario.
> Handle EDL mode properly and wait for ready instead of just exiting from the
> firmware load.
> Allow use of the Flash Programmer execution environment as a mission mode
> use case for a blank NAND power up scenario.
> Always attempt a wait for MHI ready state as device could be waiting for the
> host to do so after pass through execution environment is seen.
> Introduce patch to improve state awareness and aid in debugging.
> 
> This patch series was tested on x86_64 architecture.
> 

Applied to mhi-next!

Thanks,
Mani

> Bhaumik Bhatt (6):
>   bus: mhi: core: Rely on accurate method to determine EDL mode
>   bus: mhi: core: Wait for ready after an EDL firmware download
>   bus: mhi: core: Handle EDL mode entry appropriately
>   bus: mhi: core: Identify Flash Programmer as a mission mode use case
>   bus: mhi: core: Wait for MHI READY state in most scenarios
>   bus: mhi: core: Improve state strings for debug messages
> 
> Carl Yin (1):
>   bus: mhi: core: Add support for Flash Programmer execution environment
> 
>  drivers/bus/mhi/core/boot.c     | 13 +++++++------
>  drivers/bus/mhi/core/init.c     | 34 ++++++++++++++++++----------------
>  drivers/bus/mhi/core/internal.h |  4 +++-
>  drivers/bus/mhi/core/main.c     |  3 +++
>  drivers/bus/mhi/core/pm.c       | 28 +++++++++++++++++++++++++---
>  include/linux/mhi.h             |  4 +++-
>  6 files changed, 59 insertions(+), 27 deletions(-)
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Bhaumik Bhatt March 31, 2021, 5:01 p.m. UTC | #3
Hi Mani,
On 2021-03-31 04:16 AM, Manivannan Sadhasivam wrote:
> On Mon, Mar 29, 2021 at 06:28:17PM -0700, Bhaumik Bhatt wrote:
>> Allow handling EDL mode after SYS_ERROR occurs by reading the 
>> execution
>> environment post handling and move to power on reset state to 
>> accommodate the
>> scenario.
>> Handle EDL mode properly and wait for ready instead of just exiting 
>> from the
>> firmware load.
>> Allow use of the Flash Programmer execution environment as a mission 
>> mode
>> use case for a blank NAND power up scenario.
>> Always attempt a wait for MHI ready state as device could be waiting 
>> for the
>> host to do so after pass through execution environment is seen.
>> Introduce patch to improve state awareness and aid in debugging.
>> 
>> This patch series was tested on x86_64 architecture.
>> 
> 
> These patches were part of a different series before. It is good that
> you splitted the patches but you should mention that here.
> 
> Thanks,
> Mani
> 
I will keep that in mind when submitting next time.

>> Bhaumik Bhatt (6):
>>   bus: mhi: core: Rely on accurate method to determine EDL mode
>>   bus: mhi: core: Wait for ready after an EDL firmware download
>>   bus: mhi: core: Handle EDL mode entry appropriately
>>   bus: mhi: core: Identify Flash Programmer as a mission mode use case
>>   bus: mhi: core: Wait for MHI READY state in most scenarios
>>   bus: mhi: core: Improve state strings for debug messages
>> 
>> Carl Yin (1):
>>   bus: mhi: core: Add support for Flash Programmer execution 
>> environment
>> 
>>  drivers/bus/mhi/core/boot.c     | 13 +++++++------
>>  drivers/bus/mhi/core/init.c     | 34 
>> ++++++++++++++++++----------------
>>  drivers/bus/mhi/core/internal.h |  4 +++-
>>  drivers/bus/mhi/core/main.c     |  3 +++
>>  drivers/bus/mhi/core/pm.c       | 28 +++++++++++++++++++++++++---
>>  include/linux/mhi.h             |  4 +++-
>>  6 files changed, 59 insertions(+), 27 deletions(-)
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project
patchwork-bot+linux-arm-msm@kernel.org May 26, 2021, 7:03 p.m. UTC | #4
Hello:

This series was applied to qcom/linux.git (refs/heads/for-next):

On Mon, 29 Mar 2021 18:28:17 -0700 you wrote:
> Allow handling EDL mode after SYS_ERROR occurs by reading the execution
> environment post handling and move to power on reset state to accommodate the
> scenario.
> Handle EDL mode properly and wait for ready instead of just exiting from the
> firmware load.
> Allow use of the Flash Programmer execution environment as a mission mode
> use case for a blank NAND power up scenario.
> Always attempt a wait for MHI ready state as device could be waiting for the
> host to do so after pass through execution environment is seen.
> Introduce patch to improve state awareness and aid in debugging.
> 
> [...]

Here is the summary with links:
  - [v1,1/7] bus: mhi: core: Rely on accurate method to determine EDL mode
    https://git.kernel.org/qcom/c/418bec695696
  - [v1,2/7] bus: mhi: core: Wait for ready after an EDL firmware download
    https://git.kernel.org/qcom/c/4f214496ac74
  - [v1,3/7] bus: mhi: core: Handle EDL mode entry appropriately
    https://git.kernel.org/qcom/c/ad416db9fabe
  - [v1,4/7] bus: mhi: core: Add support for Flash Programmer execution environment
    https://git.kernel.org/qcom/c/66ac7985b2af
  - [v1,5/7] bus: mhi: core: Identify Flash Programmer as a mission mode use case
    https://git.kernel.org/qcom/c/d20e82d4d016
  - [v1,6/7] bus: mhi: core: Wait for MHI READY state in most scenarios
    https://git.kernel.org/qcom/c/e72919cebd19
  - [v1,7/7] bus: mhi: core: Improve state strings for debug messages
    https://git.kernel.org/qcom/c/19e60d6e88a6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html