diff mbox series

arm64: dts: mt8183: Add power-domains properity to mfgcfg

Message ID 20210224091742.1060508-1-ikjn@chromium.org (mailing list archive)
State New, archived
Headers show
Series arm64: dts: mt8183: Add power-domains properity to mfgcfg | expand

Commit Message

Ikjoon Jang Feb. 24, 2021, 9:17 a.m. UTC 
mfgcfg clock is under MFG_ASYNC power domain

Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
---

 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Enric Balletbo Serra Feb. 24, 2021, 10:30 a.m. UTC | #1 
Hi Ikjoon,

Thank you for your patch.

Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dc., 24 de febr.
2021 a les 10:21:
>
> mfgcfg clock is under MFG_ASYNC power domain
>
> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 5b782a4769e7..3384df5284c0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
>                         compatible = "mediatek,mt8183-mfgcfg", "syscon";
>                         reg = <0 0x13000000 0 0x1000>;
>                         #clock-cells = <1>;
> +                       power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;

I don't think this will work in mainline, at least, the reference name
should be &spm

Thanks,
  Enric
>                 };
>
>                 mmsys: syscon@14000000 {
> --
> 2.30.0.617.g56c4b15f3c-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Matthias Brugger April 1, 2021, 9:38 a.m. UTC | #2 
On 24/02/2021 11:30, Enric Balletbo Serra wrote:
> Hi Ikjoon,
> 
> Thank you for your patch.
> 
> Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dc., 24 de febr.
> 2021 a les 10:21:
>>
>> mfgcfg clock is under MFG_ASYNC power domain
>>
>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>> ---
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 5b782a4769e7..3384df5284c0 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
>>                         compatible = "mediatek,mt8183-mfgcfg", "syscon";
>>                         reg = <0 0x13000000 0 0x1000>;
>>                         #clock-cells = <1>;
>> +                       power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
> 
> I don't think this will work in mainline, at least, the reference name
> should be &spm
> 

Correct. Would you mind to resend with the comment from Enric. Apart from that,
patch looks fine to me.

Regards,
Matthias

> Thanks,
>   Enric
>>                 };
>>
>>                 mmsys: syscon@14000000 {
>> --
>> 2.30.0.617.g56c4b15f3c-goog
>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5b782a4769e7..3384df5284c0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -962,6 +962,7 @@  mfgcfg: syscon@13000000 {
 			compatible = "mediatek,mt8183-mfgcfg", "syscon";
 			reg = <0 0x13000000 0 0x1000>;
 			#clock-cells = <1>;
+			power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
 		};
 
 		mmsys: syscon@14000000 {