| Message ID | 20210325111144.2852594-7-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1,01/15] clk: qcom: dispcc-sc7180: drop unused enum entries | expand |
Hi Dmitry, Thanks for the patch for cleanup. It is okay to remove TEST source, but you can still keep the sleep clock source as it could be still connected to certain RCGs and could be used to derive low frequencies if required. As these sources are generated from the HW plans it would be good if we keep them as they are except the TEST source. On 3/25/2021 4:41 PM, Dmitry Baryshkov wrote: > Drop unused enum entries from the list of parent enums. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/videocc-sc7180.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c > index 276e5ecd4840..f5d04791a3cd 100644 > --- a/drivers/clk/qcom/videocc-sc7180.c > +++ b/drivers/clk/qcom/videocc-sc7180.c > @@ -19,8 +19,6 @@ > > enum { > P_BI_TCXO, > - P_CHIP_SLEEP_CLK, > - P_CORE_BI_PLL_TEST_SE, > P_VIDEO_PLL0_OUT_EVEN, > P_VIDEO_PLL0_OUT_MAIN, > P_VIDEO_PLL0_OUT_ODD, >
Hi Tanya, On Sat, 27 Mar 2021 at 04:49, Taniya Das <tdas@codeaurora.org> wrote: > > Hi Dmitry, > > Thanks for the patch for cleanup. > It is okay to remove TEST source, but you can still keep the sleep clock > source as it could be still connected to certain RCGs and could be used > to derive low frequencies if required. > > As these sources are generated from the HW plans it would be good if we > keep them as they are except the TEST source. Please note that I've barely removed the unused enum entry, which is not used in any of clock parent maps. So I'd suggest to either add it to relevant clock parent maps and to the videocc bindings or to drop unused enum entry. > > On 3/25/2021 4:41 PM, Dmitry Baryshkov wrote: > > Drop unused enum entries from the list of parent enums. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/clk/qcom/videocc-sc7180.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c > > index 276e5ecd4840..f5d04791a3cd 100644 > > --- a/drivers/clk/qcom/videocc-sc7180.c > > +++ b/drivers/clk/qcom/videocc-sc7180.c > > @@ -19,8 +19,6 @@ > > > > enum { > > P_BI_TCXO, > > - P_CHIP_SLEEP_CLK, > > - P_CORE_BI_PLL_TEST_SE, > > P_VIDEO_PLL0_OUT_EVEN, > > P_VIDEO_PLL0_OUT_MAIN, > > P_VIDEO_PLL0_OUT_ODD, > > > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation. > > --
On Thu, 1 Apr 2021 at 22:57, Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Dmitry Baryshkov (2021-03-27 01:13:56) > > Hi Tanya, > > > > On Sat, 27 Mar 2021 at 04:49, Taniya Das <tdas@codeaurora.org> wrote: > > > > > > Hi Dmitry, > > > > > > Thanks for the patch for cleanup. > > > It is okay to remove TEST source, but you can still keep the sleep clock > > > source as it could be still connected to certain RCGs and could be used > > > to derive low frequencies if required. > > > > > > As these sources are generated from the HW plans it would be good if we > > > keep them as they are except the TEST source. > > > > Please note that I've barely removed the unused enum entry, which is > > not used in any of clock parent maps. So I'd suggest to either add it > > to relevant clock parent maps and to the videocc bindings or to drop > > unused enum entry. > > > > Is this going to be resent? Is there a reason to resend the patches? I'm not removing any actual clock sources, only unused(!) enum entries are removed. No functional changes.
Quoting Dmitry Baryshkov (2021-04-01 13:58:28) > On Thu, 1 Apr 2021 at 22:57, Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Dmitry Baryshkov (2021-03-27 01:13:56) > > > Hi Tanya, > > > > > > On Sat, 27 Mar 2021 at 04:49, Taniya Das <tdas@codeaurora.org> wrote: > > > > > > > > Hi Dmitry, > > > > > > > > Thanks for the patch for cleanup. > > > > It is okay to remove TEST source, but you can still keep the sleep clock > > > > source as it could be still connected to certain RCGs and could be used > > > > to derive low frequencies if required. > > > > > > > > As these sources are generated from the HW plans it would be good if we > > > > keep them as they are except the TEST source. > > > > > > Please note that I've barely removed the unused enum entry, which is > > > not used in any of clock parent maps. So I'd suggest to either add it > > > to relevant clock parent maps and to the videocc bindings or to drop > > > unused enum entry. > > > > > > > Is this going to be resent? > > Is there a reason to resend the patches? > I'm not removing any actual clock sources, only unused(!) enum entries > are removed. No functional changes. > That's fine if we're just removing enums. I was hoping Taniya would respond with a reviewed-by tag or at least to this thread so we know everyone is OK.
On 3/27/2021 1:43 PM, Dmitry Baryshkov wrote: > Hi Tanya, > > On Sat, 27 Mar 2021 at 04:49, Taniya Das <tdas@codeaurora.org> wrote: >> >> Hi Dmitry, >> >> Thanks for the patch for cleanup. >> It is okay to remove TEST source, but you can still keep the sleep clock >> source as it could be still connected to certain RCGs and could be used >> to derive low frequencies if required. >> >> As these sources are generated from the HW plans it would be good if we >> keep them as they are except the TEST source. > > Please note that I've barely removed the unused enum entry, which is > not used in any of clock parent maps. So I'd suggest to either add it > to relevant clock parent maps and to the videocc bindings or to drop > unused enum entry. > Reviewed-by: Taniya Das <tdas@codeaurora.org> >> >> On 3/25/2021 4:41 PM, Dmitry Baryshkov wrote: >>> Drop unused enum entries from the list of parent enums. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> drivers/clk/qcom/videocc-sc7180.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c >>> index 276e5ecd4840..f5d04791a3cd 100644 >>> --- a/drivers/clk/qcom/videocc-sc7180.c >>> +++ b/drivers/clk/qcom/videocc-sc7180.c >>> @@ -19,8 +19,6 @@ >>> >>> enum { >>> P_BI_TCXO, >>> - P_CHIP_SLEEP_CLK, >>> - P_CORE_BI_PLL_TEST_SE, >>> P_VIDEO_PLL0_OUT_EVEN, >>> P_VIDEO_PLL0_OUT_MAIN, >>> P_VIDEO_PLL0_OUT_ODD, >>> >> >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member >> of Code Aurora Forum, hosted by The Linux Foundation. >> >> -- > > >
diff --git a/drivers/clk/qcom/videocc-sc7180.c b/drivers/clk/qcom/videocc-sc7180.c index 276e5ecd4840..f5d04791a3cd 100644 --- a/drivers/clk/qcom/videocc-sc7180.c +++ b/drivers/clk/qcom/videocc-sc7180.c @@ -19,8 +19,6 @@ enum { P_BI_TCXO, - P_CHIP_SLEEP_CLK, - P_CORE_BI_PLL_TEST_SE, P_VIDEO_PLL0_OUT_EVEN, P_VIDEO_PLL0_OUT_MAIN, P_VIDEO_PLL0_OUT_ODD,
Drop unused enum entries from the list of parent enums. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/clk/qcom/videocc-sc7180.c | 2 -- 1 file changed, 2 deletions(-)