| Message ID | 20210405101650.6779-1-penguin-kernel@I-love.SAKURA.ne.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 08c27f3322fec11950b8f1384aa0f3b11d028528 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 1 maintainers not CCed: b.a.t.m.a.n@lists.open-mesh.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 14 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Monday, 5 April 2021 12:16:50 CEST Tetsuo Handa wrote: > KMSAN found uninitialized value at batadv_tt_prepare_tvlv_local_data() > [1], for commit ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 > in TT code") inserted 'reserved' field into "struct batadv_tvlv_tt_data" > and commit 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN > specific") moved that field to "struct batadv_tvlv_tt_vlan_data" but left > that field uninitialized. > > [1] https://syzkaller.appspot.com/bug?id=07f3e6dba96f0eb3cabab986adcd8a58b9bdbe9d > > Reported-by: syzbot <syzbot+50ee810676e6a089487b@syzkaller.appspotmail.com> > Tested-by: syzbot <syzbot+50ee810676e6a089487b@syzkaller.appspotmail.com> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Fixes: ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 in TT code") > Fixes: 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN specific") > --- > net/batman-adv/translation-table.c | 2 ++ > 1 file changed, 2 insertions(+) Thanks, Acked-by: Sven Eckelmann <sven@narfation.org> > diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c > index f8761281aab0..434b4f042909 100644 > --- a/net/batman-adv/translation-table.c > +++ b/net/batman-adv/translation-table.c > @@ -890,6 +890,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, > hlist_for_each_entry(vlan, &orig_node->vlan_list, list) { > tt_vlan->vid = htons(vlan->vid); > tt_vlan->crc = htonl(vlan->tt.crc); > + tt_vlan->reserved = 0; > > tt_vlan++; > } > @@ -973,6 +974,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, > > tt_vlan->vid = htons(vlan->vid); > tt_vlan->crc = htonl(vlan->tt.crc); > + tt_vlan->reserved = 0; > > tt_vlan++; > } >
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 5 Apr 2021 19:16:50 +0900 you wrote: > KMSAN found uninitialized value at batadv_tt_prepare_tvlv_local_data() > [1], for commit ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 > in TT code") inserted 'reserved' field into "struct batadv_tvlv_tt_data" > and commit 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN > specific") moved that field to "struct batadv_tvlv_tt_vlan_data" but left > that field uninitialized. > > [...] Here is the summary with links: - [v2] batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field https://git.kernel.org/netdev/net/c/08c27f3322fe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index f8761281aab0..434b4f042909 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -890,6 +890,7 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node, hlist_for_each_entry(vlan, &orig_node->vlan_list, list) { tt_vlan->vid = htons(vlan->vid); tt_vlan->crc = htonl(vlan->tt.crc); + tt_vlan->reserved = 0; tt_vlan++; } @@ -973,6 +974,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv, tt_vlan->vid = htons(vlan->vid); tt_vlan->crc = htonl(vlan->tt.crc); + tt_vlan->reserved = 0; tt_vlan++; }
KMSAN found uninitialized value at batadv_tt_prepare_tvlv_local_data() [1], for commit ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 in TT code") inserted 'reserved' field into "struct batadv_tvlv_tt_data" and commit 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN specific") moved that field to "struct batadv_tvlv_tt_vlan_data" but left that field uninitialized. [1] https://syzkaller.appspot.com/bug?id=07f3e6dba96f0eb3cabab986adcd8a58b9bdbe9d Reported-by: syzbot <syzbot+50ee810676e6a089487b@syzkaller.appspotmail.com> Tested-by: syzbot <syzbot+50ee810676e6a089487b@syzkaller.appspotmail.com> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Fixes: ced72933a5e8ab52 ("batman-adv: use CRC32C instead of CRC16 in TT code") Fixes: 7ea7b4a142758dea ("batman-adv: make the TT CRC logic VLAN specific") --- net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+)