| Message ID | 20210406105018.59463-4-jiri.prchal@aksignal.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | SOC Codecs: TLV320AIC3X add SPI support | expand |
On Tue, Apr 06, 2021 at 12:50:16PM +0200, Jiri Prchal wrote: > +++ b/sound/soc/codecs/tlv320aic3x-i2c.c > @@ -0,0 +1,72 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * ALSA SoC TLV320AIC3x codec driver I2C interface Please make the entire comment a C++ one so things look more intentional.
On 06. 04. 21 14:13, Mark Brown wrote: > On Tue, Apr 06, 2021 at 12:50:16PM +0200, Jiri Prchal wrote: >> +++ b/sound/soc/codecs/tlv320aic3x-i2c.c >> @@ -0,0 +1,72 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * ALSA SoC TLV320AIC3x codec driver I2C interface > > Please make the entire comment a C++ one so things look more > intentional. > OK, but coding style checker complains: WARNING: Improper SPDX comment style for 'sound/soc/codecs/tlv320aic3x-i2c.c', please use '//' instead #64: FILE: sound/soc/codecs/tlv320aic3x-i2c.c:1: +/* SPDX-License-Identifier: GPL-2.0-only
On Tue, Apr 06, 2021 at 04:05:21PM +0200, Jiří Prchal wrote: > On 06. 04. 21 14:13, Mark Brown wrote: > > On Tue, Apr 06, 2021 at 12:50:16PM +0200, Jiri Prchal wrote: > > > +++ b/sound/soc/codecs/tlv320aic3x-i2c.c > > > @@ -0,0 +1,72 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > +/* > > > + * ALSA SoC TLV320AIC3x codec driver I2C interface > > Please make the entire comment a C++ one so things look more > > intentional. > OK, > but coding style checker complains: > WARNING: Improper SPDX comment style for > 'sound/soc/codecs/tlv320aic3x-i2c.c', please use '//' instead > #64: FILE: sound/soc/codecs/tlv320aic3x-i2c.c:1: > +/* SPDX-License-Identifier: GPL-2.0-only That's a C style comment not a C++ one.
diff --git a/sound/soc/codecs/tlv320aic3x-i2c.c b/sound/soc/codecs/tlv320aic3x-i2c.c new file mode 100644 index 000000000000..f77c76d25112 --- /dev/null +++ b/sound/soc/codecs/tlv320aic3x-i2c.c @@ -0,0 +1,72 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * ALSA SoC TLV320AIC3x codec driver I2C interface + * + * Author: Arun KS, <arunks@mistralsolutions.com> + * Copyright: (C) 2008 Mistral Solutions Pvt Ltd., + * + * Based on sound/soc/codecs/wm8731.c by Richard Purdie + * + */ + +#include <linux/i2c.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/regmap.h> +#include <sound/soc.h> + +#include "tlv320aic3x.h" + +static int aic3x_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *id) +{ + struct regmap *regmap; + struct regmap_config config; + + config = aic3x_regmap_config; + config.reg_bits = 8; + config.val_bits = 8; + + regmap = devm_regmap_init_i2c(i2c, &config); + return aic3x_probe(&i2c->dev, regmap, id->driver_data); +} + +static int aic3x_i2c_remove(struct i2c_client *i2c) +{ + return aic3x_remove(&i2c->dev); +} + +static const struct i2c_device_id aic3x_i2c_id[] = { + { "tlv320aic3x", AIC3X_MODEL_3X }, + { "tlv320aic33", AIC3X_MODEL_33 }, + { "tlv320aic3007", AIC3X_MODEL_3007 }, + { "tlv320aic3104", AIC3X_MODEL_3104 }, + { "tlv320aic3106", AIC3X_MODEL_3106 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, aic3x_i2c_id); + +static const struct of_device_id aic3x_of_id[] = { + { .compatible = "ti,tlv320aic3x", }, + { .compatible = "ti,tlv320aic33" }, + { .compatible = "ti,tlv320aic3007" }, + { .compatible = "ti,tlv320aic3104" }, + { .compatible = "ti,tlv320aic3106" }, + {}, +}; +MODULE_DEVICE_TABLE(of, aic3x_of_id); + +static struct i2c_driver aic3x_i2c_driver = { + .driver = { + .name = "tlv320aic3x", + .of_match_table = aic3x_of_id), + }, + .probe = aic3x_i2c_probe, + .remove = aic3x_i2c_remove, + .id_table = aic3x_i2c_id, +}; + +module_i2c_driver(aic3x_i2c_driver); + +MODULE_DESCRIPTION("ASoC TLV320AIC3x codec driver I2C"); +MODULE_AUTHOR("Arun KS <arunks@mistralsolutions.com>"); +MODULE_LICENSE("GPL");
Things related to I2C in separate file. Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz> --- sound/soc/codecs/tlv320aic3x-i2c.c | 72 ++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 sound/soc/codecs/tlv320aic3x-i2c.c