[0/2] block/rbd: fix memory leaks

Message

Stefano Garzarella March 29, 2021, 3:01 p.m. UTC

This series fixes two memory leaks, found through valgrind, in the
rbd driver.

Stefano Garzarella (2):
  block/rbd: fix memory leak in qemu_rbd_connect()
  block/rbd: fix memory leak in qemu_rbd_co_create_opts()

 block/rbd.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Max Reitz April 6, 2021, 5:06 p.m. UTC | #1

On 29.03.21 17:01, Stefano Garzarella wrote:
> This series fixes two memory leaks, found through valgrind, in the
> rbd driver.
> 
> Stefano Garzarella (2):
>    block/rbd: fix memory leak in qemu_rbd_connect()
>    block/rbd: fix memory leak in qemu_rbd_co_create_opts()
> 
>   block/rbd.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Max Reitz <[e-mail]>

I’m not quite sure whether this is fit for 6.0...  I think it’s too late 
for rc2, so I don’t know.

Max

Markus Armbruster April 7, 2021, 9:38 a.m. UTC | #2

Max Reitz <[e-mail]> writes:

> On 29.03.21 17:01, Stefano Garzarella wrote:
>> This series fixes two memory leaks, found through valgrind, in the
>> rbd driver.
>> Stefano Garzarella (2):
>>    block/rbd: fix memory leak in qemu_rbd_connect()
>>    block/rbd: fix memory leak in qemu_rbd_co_create_opts()
>>   block/rbd.c | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> Reviewed-by: Max Reitz <[e-mail]>
>
> I’m not quite sure whether this is fit for 6.0...  I think it’s too
> late for rc2, so I don’t know.

This the maintainers' call to make.

* PATCH 1:

  CON: Old bug, probably 2.9, i.e. four years

  PRO: The fix is straightforward

* PATCH 2:

  NEUTRAL: Not recent from upstream's point of view (5.0), but
  downstreams may have different ideas

  PRO: The fix is trivial

I encourage you to take at least PATCH 2.

Kevin Wolf April 7, 2021, 1:31 p.m. UTC | #3

Am 29.03.2021 um 17:01 hat Stefano Garzarella geschrieben:
> This series fixes two memory leaks, found through valgrind, in the
> rbd driver.

Thanks, applied to the block branch.

Kevin

Stefano Garzarella April 8, 2021, 7:54 a.m. UTC | #4

On Wed, Apr 07, 2021 at 11:38:17AM +0200, Markus Armbruster wrote:
>Max Reitz <[e-mail]> writes:
>
>> On 29.03.21 17:01, Stefano Garzarella wrote:
>>> This series fixes two memory leaks, found through valgrind, in the
>>> rbd driver.
>>> Stefano Garzarella (2):
>>>    block/rbd: fix memory leak in qemu_rbd_connect()
>>>    block/rbd: fix memory leak in qemu_rbd_co_create_opts()
>>>   block/rbd.c | 10 ++++++----
>>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> Reviewed-by: Max Reitz <[e-mail]>
>>
>> I’m not quite sure whether this is fit for 6.0...  I think it’s too
>> late for rc2, so I don’t know.
>
>This the maintainers' call to make.
>
>* PATCH 1:
>
>  CON: Old bug, probably 2.9, i.e. four years
>
>  PRO: The fix is straightforward
>
>* PATCH 2:
>
>  NEUTRAL: Not recent from upstream's point of view (5.0), but
>  downstreams may have different ideas
>
>  PRO: The fix is trivial
>
>I encourage you to take at least PATCH 2.
>

Kevin queued them up, thank you both for the review,
Stefano