mbox series

[00/24] USB: serial: TIOCSSERIAL fixes and generic support

Message ID 20210407103925.829-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: TIOCSSERIAL fixes and generic support | expand

Message

Johan Hovold April 7, 2021, 10:39 a.m. UTC 
TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
serial devices is only useful for setting the close_delay and
closing_wait parameters.

This series fixes up the various USB serial driver implementations,
before adding generic support to core for the benefit of all USB serial
drivers.

Johan


Johan Hovold (24):
  USB: serial: ark3116: fix TIOCGSERIAL implementation
  USB: serial: f81232: fix TIOCGSERIAL implementation
  USB: serial: f81534: fix TIOCGSERIAL implementation
  USB: serial: ftdi_sio: fix TIOCGSERIAL implementation
  USB: serial: io_edgeport: fix TIOCGSERIAL implementation
  USB: serial: io_ti: fix TIOCGSERIAL implementation
  USB: serial: mos7720: fix TIOCGSERIAL implementation
  USB: serial: mos7840: fix TIOCGSERIAL implementation
  USB: serial: opticon: fix TIOCGSERIAL implementation
  USB: serial: pl2303: fix TIOCGSERIAL implementation
  USB: serial: quatech2: fix TIOCGSERIAL implementation
  USB: serial: ssu100: fix TIOCGSERIAL implementation
  USB: serial: ti_usb_3410_5052: fix TIOCGSERIAL implementation
  USB: serial: ti_usb_3410_5052: fix TIOCSSERIAL permission check
  USB: serial: usb_wwan: fix TIOCSSERIAL jiffies conversions
  USB: serial: usb_wwan: fix unprivileged TIOCCSERIAL
  USB: serial: usb_wwan: fix TIOCGSERIAL implementation
  USB: serial: whiteheat: fix TIOCGSERIAL implementation
  USB: serial: fix return value for unsupported ioctls
  USB: serial: add generic support for TIOCSSERIAL
  USB: serial: stop reporting legacy UART types
  USB: serial: ftdi_sio: ignore baud_base changes
  USB: serial: ftdi_sio: simplify TIOCGSERIAL permission check
  USB: serial: ftdi_sio: clean up TIOCSSERIAL

 drivers/usb/serial/ark3116.c          | 13 ------
 drivers/usb/serial/f81232.c           | 11 ++---
 drivers/usb/serial/f81534.c           |  7 +---
 drivers/usb/serial/ftdi_sio.c         | 35 ++++------------
 drivers/usb/serial/io_edgeport.c      | 22 ----------
 drivers/usb/serial/io_ti.c            | 24 -----------
 drivers/usb/serial/mos7720.c          | 18 --------
 drivers/usb/serial/mos7840.c          | 23 -----------
 drivers/usb/serial/opticon.c          | 18 --------
 drivers/usb/serial/option.c           |  2 -
 drivers/usb/serial/pl2303.c           | 13 ------
 drivers/usb/serial/quatech2.c         | 16 --------
 drivers/usb/serial/ssu100.c           | 16 --------
 drivers/usb/serial/ti_usb_3410_5052.c | 38 +----------------
 drivers/usb/serial/usb-serial.c       | 59 +++++++++++++++++++++++----
 drivers/usb/serial/usb-wwan.h         |  4 --
 drivers/usb/serial/usb_wwan.c         | 45 --------------------
 drivers/usb/serial/whiteheat.c        | 17 +-------
 include/linux/usb/serial.h            |  2 +-
 19 files changed, 69 insertions(+), 314 deletions(-)

Comments

Greg Kroah-Hartman April 7, 2021, 3:23 p.m. UTC | #1 
On Wed, Apr 07, 2021 at 12:39:01PM +0200, Johan Hovold wrote:
> TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
> serial devices is only useful for setting the close_delay and
> closing_wait parameters.
> 
> This series fixes up the various USB serial driver implementations,
> before adding generic support to core for the benefit of all USB serial
> drivers.

Nice fixes!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>