| Message ID | 1617886593-36421-3-git-send-email-luojiaxing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: pm8001: tiny clean up patches | expand |
On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing <luojiaxing@huawei.com> wrote: > > There are few error about open brace is reported by checkpatch.pl: > > ERROR: that open brace { should be on the previous line > +static struct error_fw flash_error_table[] = > +{ > > So fix them all. > > Signed-off-by: Jianqin Xie <xiejianqin@hisilicon.com> > Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com> looks good to me, thx! Acked-by: Jack Wang <jinpu.wang@ionos.com> > --- > drivers/scsi/pm8001/pm8001_ctl.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c > index 90b816f..8c253b0 100644 > --- a/drivers/scsi/pm8001/pm8001_ctl.c > +++ b/drivers/scsi/pm8001/pm8001_ctl.c > @@ -645,8 +645,7 @@ struct flash_command { > int code; > }; > > -static struct flash_command flash_command_table[] = > -{ > +static const struct flash_command flash_command_table[] = { > {"set_nvmd", FLASH_CMD_SET_NVMD}, > {"update", FLASH_CMD_UPDATE}, > {"", FLASH_CMD_NONE} /* Last entry should be NULL. */ > @@ -657,8 +656,7 @@ struct error_fw { > int err_code; > }; > > -static struct error_fw flash_error_table[] = > -{ > +static const struct error_fw flash_error_table[] = { > {"Failed to open fw image file", FAIL_OPEN_BIOS_FILE}, > {"image header mismatch", FLASH_UPDATE_HDR_ERR}, > {"image offset mismatch", FLASH_UPDATE_OFFSET_ERR}, > -- > 2.7.4 >
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c index 90b816f..8c253b0 100644 --- a/drivers/scsi/pm8001/pm8001_ctl.c +++ b/drivers/scsi/pm8001/pm8001_ctl.c @@ -645,8 +645,7 @@ struct flash_command { int code; }; -static struct flash_command flash_command_table[] = -{ +static const struct flash_command flash_command_table[] = { {"set_nvmd", FLASH_CMD_SET_NVMD}, {"update", FLASH_CMD_UPDATE}, {"", FLASH_CMD_NONE} /* Last entry should be NULL. */ @@ -657,8 +656,7 @@ struct error_fw { int err_code; }; -static struct error_fw flash_error_table[] = -{ +static const struct error_fw flash_error_table[] = { {"Failed to open fw image file", FAIL_OPEN_BIOS_FILE}, {"image header mismatch", FLASH_UPDATE_HDR_ERR}, {"image offset mismatch", FLASH_UPDATE_OFFSET_ERR},
There are few error about open brace is reported by checkpatch.pl: ERROR: that open brace { should be on the previous line +static struct error_fw flash_error_table[] = +{ So fix them all. Signed-off-by: Jianqin Xie <xiejianqin@hisilicon.com> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com> --- drivers/scsi/pm8001/pm8001_ctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)