| Message ID | 20210408062647.803141-1-yebin10@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3cab801e8b94280264ba23ab0683cd3a9c13ca9f |
| Headers | show |
| Series | [-next] ASoC: rt711-sdca: Constify static struct snd_soc_dai_ops | expand |
On Thu, 8 Apr 2021 14:26:47 +0800, Ye Bin wrote: > The snd_soc_dai_ops structures is only stored in the ops field of a > snd_soc_dai_driver structure, so make the snd_soc_dai_ops structure > const to allow the compiler to put it in read-only memory. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: rt711-sdca: Constify static struct snd_soc_dai_ops commit: 3cab801e8b94280264ba23ab0683cd3a9c13ca9f All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-sdca.c index 381893b640c6..bfb7f1c8ec8f 100644 --- a/sound/soc/codecs/rt711-sdca.c +++ b/sound/soc/codecs/rt711-sdca.c @@ -1268,7 +1268,7 @@ static int rt711_sdca_pcm_hw_free(struct snd_pcm_substream *substream, #define RT711_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \ SNDRV_PCM_FMTBIT_S24_LE) -static struct snd_soc_dai_ops rt711_sdca_ops = { +static const struct snd_soc_dai_ops rt711_sdca_ops = { .hw_params = rt711_sdca_pcm_hw_params, .hw_free = rt711_sdca_pcm_hw_free, .set_sdw_stream = rt711_sdca_set_sdw_stream,
The snd_soc_dai_ops structures is only stored in the ops field of a snd_soc_dai_driver structure, so make the snd_soc_dai_ops structure const to allow the compiler to put it in read-only memory. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Ye Bin <yebin10@huawei.com> --- sound/soc/codecs/rt711-sdca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)