| Message ID | 20210407200723.1914388-6-badhri@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/6] usb: typec: tcpm: Address incorrect values of tcpm psy for fixed supply | expand |
On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote: > To allow slow charger loops to comply to pSnkStby requirement, > this patch introduces slow-charger-loop which when set makes > the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY > (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual > currrent limit after RX of PD_CTRL_PSRDY for PD link or during > SNK_READY for non-pd link. What are 'slow charger loops' and pSnkStby? 'dt-bindings: connector: ...' for the subject. Follow the pattern you see with 'git log --oneline' for a directory. > > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> > --- > .../devicetree/bindings/connector/usb-connector.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > index b6daedd62516..09ad3ad983a6 100644 > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > @@ -197,6 +197,13 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [1, 2, 3] > > + slow-charger-loop: > + description: Allows slow charging loops to comply to pSnkStby. When set makes > + the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead > + of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after > + reception of PS_Ready for PD link or during SNK_READY for non-pd link. > + type: boolean > + > required: > - compatible > > -- > 2.31.1.295.g9ea45b61b8-goog >
Hi Rob,
Have clarified "slow charger loops" and pSnkStby in my V3 of the patch
and have updated the subject as well.
I was actually doing a git log where the last one showed up with the
following commit description.
commit 4b59b60d896f3ed94921974e916db091bc3a9ba8
Author: Kyle Tso <kyletso@google.com>
Date: Fri Feb 12 15:37:43 2021 +0800
Documentation: connector: Update the description of sink-vdos
Remove the acronym "VDM" and replace it with the full name "Vendor
Defined Message".
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Kyle Tso <kyletso@google.com>
Link: https://lore.kernel.org/r/20210212073743.665038-1-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks,
Badhri
On Fri, Apr 9, 2021 at 11:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Apr 07, 2021 at 01:07:23PM -0700, Badhri Jagan Sridharan wrote:
> > To allow slow charger loops to comply to pSnkStby requirement,
> > this patch introduces slow-charger-loop which when set makes
> > the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY
> > (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual
> > currrent limit after RX of PD_CTRL_PSRDY for PD link or during
> > SNK_READY for non-pd link.
>
> What are 'slow charger loops' and pSnkStby?
>
> 'dt-bindings: connector: ...' for the subject. Follow the pattern you
> see with 'git log --oneline' for a directory.
>
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> > ---
> > .../devicetree/bindings/connector/usb-connector.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > index b6daedd62516..09ad3ad983a6 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > @@ -197,6 +197,13 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [1, 2, 3]
> >
> > + slow-charger-loop:
> > + description: Allows slow charging loops to comply to pSnkStby. When set makes
> > + the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead
> > + of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after
> > + reception of PS_Ready for PD link or during SNK_READY for non-pd link.
> > + type: boolean
> > +
> > required:
> > - compatible
> >
> > --
> > 2.31.1.295.g9ea45b61b8-goog
> >
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml index b6daedd62516..09ad3ad983a6 100644 --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml @@ -197,6 +197,13 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 enum: [1, 2, 3] + slow-charger-loop: + description: Allows slow charging loops to comply to pSnkStby. When set makes + the port request pSnkStby(2.5W - 5V@500mA) upon entering SNK_DISCOVERY(instead + of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after + reception of PS_Ready for PD link or during SNK_READY for non-pd link. + type: boolean + required: - compatible
To allow slow charger loops to comply to pSnkStby requirement, this patch introduces slow-charger-loop which when set makes the port request PD_P_SNK_STDBY_MW upon entering SNK_DISCOVERY (instead of 3A or the 1.5A during SNK_DISCOVERY) and the actual currrent limit after RX of PD_CTRL_PSRDY for PD link or during SNK_READY for non-pd link. Signed-off-by: Badhri Jagan Sridharan <badhri@google.com> --- .../devicetree/bindings/connector/usb-connector.yaml | 7 +++++++ 1 file changed, 7 insertions(+)