[0/4] USB: serial: closing-wait fixes and cleanups

Message

Johan Hovold April 12, 2021, 9:38 a.m. UTC

The port drain_delay parameter is used to add a time-based delay when
closing the port in order to allow the transmit FIFO to drain in cases
where we don't know how to tell if the FIFO is empty.

This series removes a redundant time-based delay which is no longer
needed, and documents the reason for two other uses where such a delay
is needed to let the transmitter shift register clear. As it turns out,
this is really only needed for one of the two device types handled by
the ti_usb_3410_5052 driver.

Johan


Johan Hovold (4):
  USB: serial: f81232: drop time-based drain delay
  USB: serial: io_ti: document reason for drain delay
  USB: serial: ti_usb_3410_5052: reduce drain delay to one char
  USB: serial: ti_usb_3410_5052: drop drain delay for 3410

 drivers/usb/serial/f81232.c           |  1 -
 drivers/usb/serial/io_ti.c            |  4 ++++
 drivers/usb/serial/ti_usb_3410_5052.c | 21 ++++++++++++++++++---
 3 files changed, 22 insertions(+), 4 deletions(-)

Comments

Greg Kroah-Hartman April 12, 2021, 9:52 a.m. UTC | #1

On Mon, Apr 12, 2021 at 11:38:11AM +0200, Johan Hovold wrote:
> The port drain_delay parameter is used to add a time-based delay when
> closing the port in order to allow the transmit FIFO to drain in cases
> where we don't know how to tell if the FIFO is empty.
> 
> This series removes a redundant time-based delay which is no longer
> needed, and documents the reason for two other uses where such a delay
> is needed to let the transmitter shift register clear. As it turns out,
> this is really only needed for one of the two device types handled by
> the ti_usb_3410_5052 driver.

Reviewed-by: Greg Kroah-Hartman <[e-mail]>