| Message ID | 20210412130521.782373-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet | expand |
On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote: > This is another branded 8153 device that doesn't work well with LPM > enabled: > [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71 > > So disable LPM to resolve the issue. > > BugLink: https://bugs.launchpad.net/bugs/1922651 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: > - Put the quirk in the right order. Seriously... You sent the exact same patch again. Still not ordered. > > drivers/usb/core/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 76ac5d6555ae..dfedb51cf832 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = { > { USB_DEVICE(0x1532, 0x0116), .driver_info = > USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, > > + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */ > + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM }, > + > /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */ > { USB_DEVICE(0x17ef, 0xa012), .driver_info = > USB_QUIRK_DISCONNECT_SUSPEND }, Johan
On Mon, Apr 12, 2021 at 9:09 PM Johan Hovold <johan@kernel.org> wrote: > > On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote: > > This is another branded 8153 device that doesn't work well with LPM > > enabled: > > [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71 > > > > So disable LPM to resolve the issue. > > > > BugLink: https://bugs.launchpad.net/bugs/1922651 > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > --- > > v2: > > - Put the quirk in the right order. > > Seriously... You sent the exact same patch again. Still not ordered. Oops, sorry for that, I mistyped the patch name :( Will send a correct one. Kai-Heng > > > > > drivers/usb/core/quirks.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > > index 76ac5d6555ae..dfedb51cf832 100644 > > --- a/drivers/usb/core/quirks.c > > +++ b/drivers/usb/core/quirks.c > > @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = { > > { USB_DEVICE(0x1532, 0x0116), .driver_info = > > USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, > > > > + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */ > > + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM }, > > + > > /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */ > > { USB_DEVICE(0x17ef, 0xa012), .driver_info = > > USB_QUIRK_DISCONNECT_SUSPEND }, > > Johan
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 76ac5d6555ae..dfedb51cf832 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x1532, 0x0116), .driver_info = USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */ + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM }, + /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */ { USB_DEVICE(0x17ef, 0xa012), .driver_info = USB_QUIRK_DISCONNECT_SUSPEND },
This is another branded 8153 device that doesn't work well with LPM enabled: [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71 So disable LPM to resolve the issue. BugLink: https://bugs.launchpad.net/bugs/1922651 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- v2: - Put the quirk in the right order. drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+)