mbox series

[00/10] USB: serial: clean up the ti drivers

Message ID 20210412094738.944-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: clean up the ti drivers | expand

Message

Johan Hovold April 12, 2021, 9:47 a.m. UTC 
The io_ti and ti_usb_3410_5052 drivers are drivers for devices based on
the same TI chips and one appears to have been based on the other
judging from the code similarities.

This series clean up their implementations a bit by introducing
port-command helpers and fixing up some related style inconsistencies.

This is based on top of the recently posted closing-wait series.

Johan


Johan Hovold (10):
  USB: serial: io_ti: clean up vendor-request helpers
  USB: serial: io_ti: add send-port-command helper
  USB: serial: io_ti: add read-port-command helper
  USB: serial: io_ti: use kernel types consistently
  USB: serial: io_ti: drop unnecessary packed attributes
  USB: serial: ti_usb_3410_5052: drop unnecessary packed attributes
  USB: serial: ti_usb_3410_5052: clean up vendor-request helpers
  USB: serial: ti_usb_3410_5052: add port-command helpers
  USB: serial: ti_usb_3410_5052: use kernel types consistently
  USB: serial: ti_usb_3410_5052: clean up termios CSIZE handling

 drivers/usb/serial/io_ti.c            | 175 ++++++++++++--------------
 drivers/usb/serial/io_ti.h            |  38 +++---
 drivers/usb/serial/ti_usb_3410_5052.c | 146 +++++++++++----------
 3 files changed, 170 insertions(+), 189 deletions(-)

Comments

Greg Kroah-Hartman April 12, 2021, 10:59 a.m. UTC | #1 
On Mon, Apr 12, 2021 at 11:47:28AM +0200, Johan Hovold wrote:
> The io_ti and ti_usb_3410_5052 drivers are drivers for devices based on
> the same TI chips and one appears to have been based on the other
> judging from the code similarities.

All I had to work off of was a vendor-driver for the ti_usb_3410_5052
codebase and trying to figure out what was common and what wasn't was
pretty hard at the time.  Thanks for working on this cleanup now.

> 
> This series clean up their implementations a bit by introducing
> port-command helpers and fixing up some related style inconsistencies.
> 
> This is based on top of the recently posted closing-wait series.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold April 13, 2021, 4:31 p.m. UTC | #2 
On Mon, Apr 12, 2021 at 12:59:40PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 12, 2021 at 11:47:28AM +0200, Johan Hovold wrote:
> > The io_ti and ti_usb_3410_5052 drivers are drivers for devices based on
> > the same TI chips and one appears to have been based on the other
> > judging from the code similarities.
> 
> All I had to work off of was a vendor-driver for the ti_usb_3410_5052
> codebase and trying to figure out what was common and what wasn't was
> pretty hard at the time.  Thanks for working on this cleanup now.

Ah, thanks. That explains the similarities.

> > This series clean up their implementations a bit by introducing
> > port-command helpers and fixing up some related style inconsistencies.
> > 
> > This is based on top of the recently posted closing-wait series.
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

And thanks for reviewing both of these sets. Now applied.

Johan