mbox series

[0/9] Updates for mmsd

Message ID 051ae8ae27f5288d64ec6ef2bd9f77c06b829b52.camel@talbothome.com (mailing list archive)
Headers show
Series Updates for mmsd | expand

Message

Chris Talbot April 10, 2021, 2:13 p.m. UTC
Hello,

I am submitting a series of patches for mmsd that I have been working
on. The patches have been successfully tested on PostmarketOS, Debian
on Mobile (Mobian), PureOS, and Fedora.

The patches fall into two catagories:
1) core fixes to mmsd to get it to work with several carriers
(including T-Mobile USA, AT&T USA, Telus Canada, and a Swedish
Carrier). 
2) A new plugin to enable mmsd functionality on Modem Manager. 

The Patches have been tested on both the Pinephone and the Librem 5,
and have been confirmed tested accross all major US carriers (as well
as several minor US carriers), Canadian carriers, French carriers, and
Swedish carriers. They been been likely tested on more carriers, but
the author can only confirm the above ones (as he has gotten positive
feedback for them).

Comments

Chris Talbot April 14, 2021, 6:21 p.m. UTC | #1
Hello All,

In talking to the Debian Developer Mr. Federico Ceratto, since I have
been unable to get a hold of the Ofono Maintainers, the best course of
action for packaging mmsd into Debian is to simply fork the project and
submit my version upstream for packaging in Debian. My repository is
here: https://source.puri.sm/kop316/mmsd/

I am sending this so the relavent parties are aware of this, and to
indicate that I no longer intend on trying to get a hold of upstream
mmsd to try and submit patches.

For the Purism Employees, I am additionally asking for permission to
keep hosting mmsd on https://source.puri.sm/ . I have been extremely
appreciative in using it and I am happy to keep it there, but I want to
be neighboorly and ask if it is okay for me to keep it there. If it is
not, I completely understand and I am fine with moving it to a new
host.

If you have any questions, comments, or concern, please reach out to
me.
Guido Günther April 14, 2021, 6:30 p.m. UTC | #2
Hi,
On Wed, Apr 14, 2021 at 02:21:04PM -0400, Chris Talbot wrote:
> Hello All,
> 
> In talking to the Debian Developer Mr. Federico Ceratto, since I have
> been unable to get a hold of the Ofono Maintainers, the best course of
> action for packaging mmsd into Debian is to simply fork the project and
> submit my version upstream for packaging in Debian. My repository is
> here: https://source.puri.sm/kop316/mmsd/
> 
> I am sending this so the relavent parties are aware of this, and to
> indicate that I no longer intend on trying to get a hold of upstream
> mmsd to try and submit patches.
> 
> For the Purism Employees, I am additionally asking for permission to
> keep hosting mmsd on https://source.puri.sm/ . I have been extremely
> appreciative in using it and I am happy to keep it there, but I want to
> be neighboorly and ask if it is okay for me to keep it there. If it is
> not, I completely understand and I am fine with moving it to a new
> host.

Keeping your ofono version on source.puri.sm is certainly welcome!
Cheers,
 -- Guido

> 
> If you have any questions, comments, or concern, please reach out to
> me.
> 
> -- 
> Respectfully,
> Chris Talbot
> 
> 
> _______________________________________________
> Debian-on-mobile-maintainers mailing list
> Debian-on-mobile-maintainers@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-on-mobile-maintainers
>
Marius Gripsgard April 14, 2021, 6:39 p.m. UTC | #3
Hi,

I would really like to avoid a fork, it's not worth doing dual work. Did you ping ofono devs at irc?  Also have you sendt upstream patches? If a fork is the way you want to go, you will need to rename it as the existing packages need to follow upstream, we can't just rip an existing packages away from upstream.

Best regards,
Marius

Apr 14, 2021 20:21:18 Chris Talbot <chris@talbothome.com>:

> Hello All,
> 
> In talking to the Debian Developer Mr. Federico Ceratto, since I have
> been unable to get a hold of the Ofono Maintainers, the best course of
> action for packaging mmsd into Debian is to simply fork the project and
> submit my version upstream for packaging in Debian. My repository is
> here: https://source.puri.sm/kop316/mmsd/
> 
> I am sending this so the relavent parties are aware of this, and to
> indicate that I no longer intend on trying to get a hold of upstream
> mmsd to try and submit patches.
> 
> For the Purism Employees, I am additionally asking for permission to
> keep hosting mmsd on https://source.puri.sm/ . I have been extremely
> appreciative in using it and I am happy to keep it there, but I want to
> be neighboorly and ask if it is okay for me to keep it there. If it is
> not, I completely understand and I am fine with moving it to a new
> host.
> 
> If you have any questions, comments, or concern, please reach out to
> me.
> 
> -- 
> Respectfully,
> Chris Talbot
> _______________________________________________
> ofono mailing list -- ofono@ofono.org
> To unsubscribe send an email to ofono-leave@ofono.org
Chris Talbot April 14, 2021, 6:46 p.m. UTC | #4
Hello,

On Wed, 2021-04-14 at 20:30 +0200, Guido Günther wrote:
> Hi,
> On Wed, Apr 14, 2021 at 02:21:04PM -0400, Chris Talbot wrote:
> > Hello All,
> > 
> > In talking to the Debian Developer Mr. Federico Ceratto, since I
> > have
> > been unable to get a hold of the Ofono Maintainers, the best course
> > of
> > action for packaging mmsd into Debian is to simply fork the project
> > and
> > submit my version upstream for packaging in Debian. My repository
> > is
> > here: https://source.puri.sm/kop316/mmsd/
> > 
> > I am sending this so the relavent parties are aware of this, and to
> > indicate that I no longer intend on trying to get a hold of
> > upstream
> > mmsd to try and submit patches.
> > 
> > For the Purism Employees, I am additionally asking for permission
> > to
> > keep hosting mmsd on https://source.puri.sm/ . I have been
> > extremely
> > appreciative in using it and I am happy to keep it there, but I
> > want to
> > be neighboorly and ask if it is okay for me to keep it there. If it
> > is
> > not, I completely understand and I am fine with moving it to a new
> > host.
> 
> Keeping your ofono version on source.puri.sm is certainly welcome!
> Cheers,
>  -- Guido
> 
> > 
> > If you have any questions, comments, or concern, please reach out
> > to
> > me.
> > 
> > -- 
> > Respectfully,
> > Chris Talbot
> > 
> > 
> > _______________________________________________
> > Debian-on-mobile-maintainers mailing list
> > Debian-on-mobile-maintainers@alioth-lists.debian.net
> > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-on-mobile-maintainers
> > 
Thank you for allowing me to keep hosting it there.

Since it is now a fork, I added Mr. Ceratto, Mr. Farraris (a-wai), and
Mr. Clayton Craft (craftyguy, a pmOS developer) as maintainers. Is
there a wish for a Purism maintainer to be added as well? 

Respectfully,
Chris Talbot
Pavel Machek April 14, 2021, 7:29 p.m. UTC | #5
Hi!

> In talking to the Debian Developer Mr. Federico Ceratto, since I have
> been unable to get a hold of the Ofono Maintainers, the best course of
> action for packaging mmsd into Debian is to simply fork the project and
> submit my version upstream for packaging in Debian. My repository is
> here: https://source.puri.sm/kop316/mmsd/

Ofono maintainers are normally pretty responsive, and yes, you seem to
be cc-ing the right list.

I don't think forking ofono is good idea.

Best regards,
								Pavel
Paul Wise April 14, 2021, 9:11 p.m. UTC | #6
On Wed, Apr 14, 2021 at 7:42 PM Pavel Machek wrote:

> I don't think forking ofono is good idea.

I'd like to point out that this isn't ofono that is being forked, but mmsd.
Wookey April 14, 2021, 10:09 p.m. UTC | #7
On 2021-04-14 18:39 +0000, Marius Gripsgard wrote:

> I would really like to avoid a fork, it's not worth doing dual
> work. Did you ping ofono devs at irc?  Also have you sent upstream
> patches? If a fork is the way you want to go, you will need to
> rename it as the existing packages need to follow upstream, we can't
> just rip an existing packages away from upstream.

Debian can package mmsd with whatever set of patches it sees fit. If
the end result is ChrisT's version, with Modem Manager support, then I
think that's reasonable. mmsd is not currently packaged in debian so I
don't think a rename is required. Ultimately it's up to maintainers to
choose which upstream is most appropriate. There used to be only one,
but increasingly one gets a choice of varying degrees of active
maintenance. (This can be a huge pain making life quite awkward for
maintainers, and I find Debian is the only org trying to unify a
diverse set of versions where a load of people have scratched their
own itch and then just left it like that.)

Ultimately we want the best functionality for our users, and if the
old upstream has been inactive for years then using this new,
maintained version of mmsd may well be the best course. Efforts should
continue to either give Chris access to the original repo or
officially declare it 'under new management' so that there is a
canonical place for the codebase, but in the meantime it's OK for
debian to have a big patch.

Versioning could be tricky in some situations, but SFACT the ofono
mmsd is just 0.0 so the debian version can be 0.0.something and remain
compatible with a shift back to that repo at some point.

Wookey
Chris Talbot April 15, 2021, 12:12 a.m. UTC | #8
Hello!

On Wed, 2021-04-14 at 23:09 +0100, Wookey wrote:
> On 2021-04-14 18:39 +0000, Marius Gripsgard wrote:
> 
> > I would really like to avoid a fork, it's not worth doing dual
> > work. Did you ping ofono devs at irc?  Also have you sent upstream
> > patches? If a fork is the way you want to go, you will need to
> > rename it as the existing packages need to follow upstream, we
> > can't
> > just rip an existing packages away from upstream.
> 
> Debian can package mmsd with whatever set of patches it sees fit. If
> the end result is ChrisT's version, with Modem Manager support, then
> I
> think that's reasonable. mmsd is not currently packaged in debian so
> I
> don't think a rename is required. Ultimately it's up to maintainers
> to
> choose which upstream is most appropriate. There used to be only one,
> but increasingly one gets a choice of varying degrees of active
> maintenance. (This can be a huge pain making life quite awkward for
> maintainers, and I find Debian is the only org trying to unify a
> diverse set of versions where a load of people have scratched their
> own itch and then just left it like that.)
> 

At this point, fork of mmsd should still work with ofono. I have not
disturbed anything ofono related, and have made several improvements to
the core that should benefit ofono too.

I would in addition welcome someone from ofono to work with me! I would
rather mmsd work with both stacks (as we all benefit from that). The
Mobian and PostmarketOS developers have welcomed me, and I am happy to
work with you all too. I joined the UBports matrix channel and
introduced myself (in addition to asking how you all contact the ofono
folks), you are free to reach out to me.

> Ultimately we want the best functionality for our users, and if the
> old upstream has been inactive for years then using this new,
> maintained version of mmsd may well be the best course. Efforts
> should
> continue to either give Chris access to the original repo or
> officially declare it 'under new management' so that there is a
> canonical place for the codebase, but in the meantime it's OK for
> debian to have a big patch.
> 

I admittedly do not know who to contact for repo access? I asked on the
Kernelnewbies IRC/Mailing list (as I am a bit of a kernel newbie), but
I did not hear anything back.

I am not trying to start a fork because I want to, and if you look at
Ofono's ML history, you can see that I have tried a lot to work with
upstream. I am starting a fork because I feel this is the only way I
can really move forward in getting MMS working. Without MMS,
unfortunately the Pinephone I have is little more than a toy with me,
and I put a lot of work into getting MMS working on the Modem Manager
stack.

> Versioning could be tricky in some situations, but SFACT the ofono
> mmsd is just 0.0 so the debian version can be 0.0.something and
> remain
> compatible with a shift back to that repo at some point.
> 
> Wookey

Thank you!

Respectfully,
Chris Talbot
Guido Günther April 15, 2021, 9:10 a.m. UTC | #9
Hi Chris,
On Wed, Apr 14, 2021 at 02:46:30PM -0400, Chris Talbot wrote:
> Hello,
> 
> On Wed, 2021-04-14 at 20:30 +0200, Guido Günther wrote:
> > Hi,
> > On Wed, Apr 14, 2021 at 02:21:04PM -0400, Chris Talbot wrote:
> > > Hello All,
> > > 
> > > In talking to the Debian Developer Mr. Federico Ceratto, since I
> > > have
> > > been unable to get a hold of the Ofono Maintainers, the best course
> > > of
> > > action for packaging mmsd into Debian is to simply fork the project
> > > and
> > > submit my version upstream for packaging in Debian. My repository
> > > is
> > > here: https://source.puri.sm/kop316/mmsd/
> > > 
> > > I am sending this so the relavent parties are aware of this, and to
> > > indicate that I no longer intend on trying to get a hold of
> > > upstream
> > > mmsd to try and submit patches.
> > > 
> > > For the Purism Employees, I am additionally asking for permission
> > > to
> > > keep hosting mmsd on https://source.puri.sm/ . I have been
> > > extremely
> > > appreciative in using it and I am happy to keep it there, but I
> > > want to
> > > be neighboorly and ask if it is okay for me to keep it there. If it
> > > is
> > > not, I completely understand and I am fine with moving it to a new
> > > host.
> > 
> > Keeping your ofono version on source.puri.sm is certainly welcome!
> > Cheers,
> >  -- Guido
> > 
> > > 
> > > If you have any questions, comments, or concern, please reach out
> > > to
> > > me.
> > > 
> > > -- 
> > > Respectfully,
> > > Chris Talbot
> > > 
> > > 
> > > _______________________________________________
> > > Debian-on-mobile-maintainers mailing list
> > > Debian-on-mobile-maintainers@alioth-lists.debian.net
> > > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-on-mobile-maintainers
> > > 
> Thank you for allowing me to keep hosting it there.

Great. If you really want to maintain a fork i'd consider renaming to
make that obvious (e.g. mm-mmsd) to avoid confusion within distros.

> Since it is now a fork, I added Mr. Ceratto, Mr. Farraris (a-wai), and
> Mr. Clayton Craft (craftyguy, a pmOS developer) as maintainers. Is
> there a wish for a Purism maintainer to be added as well?
I think sadiq and devrtz were the ones most involved so far but i think
working via MRs is fine since that allows to establish a workflow.

Cheers,
 -- Guido


> Respectfully,
> Chris Talbot
>