diff mbox series

[v4,3/3] dt-bindings: connector: Add slow-charger-loop definition

Message ID 20210414142656.63749-3-badhri@google.com (mailing list archive)
State Accepted
Commit ca0584c40a6648ae2c7f2ef50446af2f7bdf82db
Headers show
Series [v4,1/3] usb: typec: tcpm: Honour pSnkStdby requirement during negotiation | expand

Commit Message

Badhri Jagan Sridharan April 14, 2021, 2:26 p.m. UTC
Allows PMIC charger loops which are slow(i.e. cannot meet the
15ms deadline) to still comply to pSnkStby i.e Maximum power
that can be consumed by sink while in Sink Standby state as defined
in 7.4.2 Sink Electrical Parameters of USB Power Delivery Specification
Revision 3.0, Version 1.2.

This patch introduces slow-charger-loop which when set makes
the port request PD_P_SNK_STDBY_MW(2.5W i.e 500mA@5V) upon entering
SNK_DISCOVERY (instead of 3A or the 1.5A during SNK_DISCOVERY) and the
actual currrent limit after RX of PD_CTRL_PSRDY for PD link or during
SNK_READY for non-pd link.

Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
---
Changes since v3:
* Removed additional semi-colon in the subject line
Changes since V2:
To address Rob's comments
* Updated commit and the binding description.
* Updated subject as well.
---
 .../devicetree/bindings/connector/usb-connector.yaml   | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Rob Herring (Arm) April 15, 2021, 4:22 p.m. UTC | #1
On Wed, 14 Apr 2021 07:26:56 -0700, Badhri Jagan Sridharan wrote:
> Allows PMIC charger loops which are slow(i.e. cannot meet the
> 15ms deadline) to still comply to pSnkStby i.e Maximum power
> that can be consumed by sink while in Sink Standby state as defined
> in 7.4.2 Sink Electrical Parameters of USB Power Delivery Specification
> Revision 3.0, Version 1.2.
> 
> This patch introduces slow-charger-loop which when set makes
> the port request PD_P_SNK_STDBY_MW(2.5W i.e 500mA@5V) upon entering
> SNK_DISCOVERY (instead of 3A or the 1.5A during SNK_DISCOVERY) and the
> actual currrent limit after RX of PD_CTRL_PSRDY for PD link or during
> SNK_READY for non-pd link.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
> ---
> Changes since v3:
> * Removed additional semi-colon in the subject line
> Changes since V2:
> To address Rob's comments
> * Updated commit and the binding description.
> * Updated subject as well.
> ---
>  .../devicetree/bindings/connector/usb-connector.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index b6daedd62516..32509b98142e 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -197,6 +197,16 @@  properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum: [1, 2, 3]
 
+  slow-charger-loop:
+    description: Allows PMIC charger loops which are slow(i.e. cannot meet the 15ms deadline) to
+      still comply to pSnkStby i.e Maximum power that can be consumed by sink while in Sink Standby
+      state as defined in 7.4.2 Sink Electrical Parameters of USB Power Delivery Specification
+      Revision 3.0, Version 1.2. When the property is set, the port requests pSnkStby(2.5W -
+      5V@500mA) upon entering SNK_DISCOVERY(instead of 3A or the 1.5A, Rp current advertised, during
+      SNK_DISCOVERY) and the actual currrent limit after reception of PS_Ready for PD link or during
+      SNK_READY for non-pd link.
+    type: boolean
+
 required:
   - compatible