[ipsec-next,0/3] xfrm: minor cleanup and synchronize_rcu removal

Message

Florian Westphal April 14, 2021, 4:12 p.m. UTC

First patch gets rid of SPI key from flowi struct.
xfrm_policy populates this but there are no consumers.

This is part of a different patch (not part of this) to replace
xfrm_decode_session internals with the flow dissector.

Second patch removes a synchronize_rcu/initialisation in the init path.
Third patch avoids a synchronize_rcu during netns destruction.

Florian Westphal (3):
  flow: remove spi key from flowi struct
  xfrm: remove stray synchronize_rcu from xfrm_init
  xfrm: avoid synchronize_rcu during netns destruction

 include/net/flow.h     |  3 ---
 net/xfrm/xfrm_policy.c | 42 ------------------------------------------
 net/xfrm/xfrm_user.c   | 10 +++++++---
 3 files changed, 7 insertions(+), 48 deletions(-)

Comments

Steffen Klassert April 20, 2021, 11:56 a.m. UTC | #1

On Wed, Apr 14, 2021 at 06:12:50PM +0200, Florian Westphal wrote:
> First patch gets rid of SPI key from flowi struct.
> xfrm_policy populates this but there are no consumers.
> 
> This is part of a different patch (not part of this) to replace
> xfrm_decode_session internals with the flow dissector.
> 
> Second patch removes a synchronize_rcu/initialisation in the init path.
> Third patch avoids a synchronize_rcu during netns destruction.
> 
> Florian Westphal (3):
>   flow: remove spi key from flowi struct
>   xfrm: remove stray synchronize_rcu from xfrm_init
>   xfrm: avoid synchronize_rcu during netns destruction

Applied, thanks a lot Florian!