| Message ID | 20210420032018.58639-8-saeed@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 704cfecdd03d7b84403ed96ba0009ea07270e74e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/15] net/mlx5e: Fix lost changes during code movements | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Pull request |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: linux-rdma@vger.kernel.org leon@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 8 this patch: 8 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 65 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/header_inline | success | Link |
On 4/19/2021 8:20 PM, Saeed Mahameed wrote: > From: Yevgeny Kliteynik <kliteyn@nvidia.com> > > Added the required definitions for supporting more protocols by flex parsers > (GTP-U, Geneve TLV options), and for using the right flex parser that was > configured for this protocol. Are you planning to support adding flow rules to match on these protocol specific fields? If so, are you planning to extend tc flower OR use other interfaces? > Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> > --- > include/linux/mlx5/mlx5_ifc.h | 32 ++++++++++++++++++++++++++++---- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h > index f2c51d6833c6..aa6effe1dd6d 100644 > --- a/include/linux/mlx5/mlx5_ifc.h > +++ b/include/linux/mlx5/mlx5_ifc.h > @@ -622,7 +622,19 @@ struct mlx5_ifc_fte_match_set_misc3_bits { > > u8 geneve_tlv_option_0_data[0x20]; > > - u8 reserved_at_140[0xc0]; > + u8 gtpu_teid[0x20]; > + > + u8 gtpu_msg_type[0x8]; > + u8 gtpu_msg_flags[0x8]; > + u8 reserved_at_170[0x10]; > + > + u8 gtpu_dw_2[0x20]; > + > + u8 gtpu_first_ext_dw_0[0x20]; > + > + u8 gtpu_dw_0[0x20]; > + > + u8 reserved_at_1e0[0x20]; > }; > > struct mlx5_ifc_fte_match_set_misc4_bits { > @@ -1237,9 +1249,17 @@ enum { > > enum { > MLX5_FLEX_PARSER_GENEVE_ENABLED = 1 << 3, > + MLX5_FLEX_PARSER_MPLS_OVER_GRE_ENABLED = 1 << 4, > + mlx5_FLEX_PARSER_MPLS_OVER_UDP_ENABLED = 1 << 5, > MLX5_FLEX_PARSER_VXLAN_GPE_ENABLED = 1 << 7, > MLX5_FLEX_PARSER_ICMP_V4_ENABLED = 1 << 8, > MLX5_FLEX_PARSER_ICMP_V6_ENABLED = 1 << 9, > + MLX5_FLEX_PARSER_GENEVE_TLV_OPTION_0_ENABLED = 1 << 10, > + MLX5_FLEX_PARSER_GTPU_ENABLED = 1 << 11, > + MLX5_FLEX_PARSER_GTPU_DW_2_ENABLED = 1 << 16, > + MLX5_FLEX_PARSER_GTPU_FIRST_EXT_DW_0_ENABLED = 1 << 17, > + MLX5_FLEX_PARSER_GTPU_DW_0_ENABLED = 1 << 18, > + MLX5_FLEX_PARSER_GTPU_TEID_ENABLED = 1 << 19, > }; > > enum { > @@ -1637,7 +1657,9 @@ struct mlx5_ifc_cmd_hca_cap_bits { > u8 cqe_compression_timeout[0x10]; > u8 cqe_compression_max_num[0x10]; > > - u8 reserved_at_5e0[0x10]; > + u8 reserved_at_5e0[0x8]; > + u8 flex_parser_id_gtpu_dw_0[0x4]; > + u8 reserved_at_5ec[0x4]; > u8 tag_matching[0x1]; > u8 rndv_offload_rc[0x1]; > u8 rndv_offload_dc[0x1]; > @@ -1648,7 +1670,8 @@ struct mlx5_ifc_cmd_hca_cap_bits { > u8 affiliate_nic_vport_criteria[0x8]; > u8 native_port_num[0x8]; > u8 num_vhca_ports[0x8]; > - u8 reserved_at_618[0x6]; > + u8 flex_parser_id_gtpu_teid[0x4]; > + u8 reserved_at_61c[0x2]; > u8 sw_owner_id[0x1]; > u8 reserved_at_61f[0x1]; > > @@ -1683,7 +1706,8 @@ struct mlx5_ifc_cmd_hca_cap_bits { > u8 reserved_at_6e0[0x10]; > u8 sf_base_id[0x10]; > > - u8 reserved_at_700[0x8]; > + u8 flex_parser_id_gtpu_dw_2[0x4]; > + u8 flex_parser_id_gtpu_first_ext_dw_0[0x4]; > u8 num_total_dynamic_vf_msix[0x18]; > u8 reserved_at_720[0x14]; > u8 dynamic_msix_table_size[0xc];
On 20-Apr-21 07:54, Samudrala, Sridhar wrote: > External email: Use caution opening links or attachments > > > On 4/19/2021 8:20 PM, Saeed Mahameed wrote: >> From: Yevgeny Kliteynik <kliteyn@nvidia.com> >> >> Added the required definitions for supporting more protocols by flex >> parsers >> (GTP-U, Geneve TLV options), and for using the right flex parser that was >> configured for this protocol. > Are you planning to support adding flow rules to match on these protocol > specific fields? > If so, are you planning to extend tc flower OR use other interfaces? Some of these are already supported through tc on DMFS. This patch series adds support for SMFS: Geneve options and MPLS both through tc and through rdma-core on root table, and GTP-U is supported only through rdma-core on root table. -- YK >> Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com> >> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> >> --- >> include/linux/mlx5/mlx5_ifc.h | 32 ++++++++++++++++++++++++++++---- >> 1 file changed, 28 insertions(+), 4 deletions(-) >>
On 4/20/2021 10:07 AM, Yevgeny Kliteynik wrote: > > On 20-Apr-21 07:54, Samudrala, Sridhar wrote: >> External email: Use caution opening links or attachments >> >> >> On 4/19/2021 8:20 PM, Saeed Mahameed wrote: >>> From: Yevgeny Kliteynik <kliteyn@nvidia.com> >>> >>> Added the required definitions for supporting more protocols by flex >>> parsers >>> (GTP-U, Geneve TLV options), and for using the right flex parser >>> that was >>> configured for this protocol. >> Are you planning to support adding flow rules to match on these protocol >> specific fields? >> If so, are you planning to extend tc flower OR use other interfaces? > > Some of these are already supported through tc on DMFS. > This patch series adds support for SMFS: Geneve options and MPLS > both through tc and through rdma-core on root table, > and GTP-U is supported only through rdma-core on root table. What is the interface for rdma-core to hook into the driver to add these rules? Is there an equivalent of ndo_setup_tc() that is used with tc interface? > > -- YK > >>> Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com> >>> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> >>> --- >>> � include/linux/mlx5/mlx5_ifc.h | 32 ++++++++++++++++++++++++++++---- >>> � 1 file changed, 28 insertions(+), 4 deletions(-) >>>
On 21-Apr-21 18:08, Samudrala, Sridhar wrote: >>>> Added the required definitions for supporting more protocols by flex >>>> parsers >>>> (GTP-U, Geneve TLV options), and for using the right flex parser >>>> that was >>>> configured for this protocol. >>> Are you planning to support adding flow rules to match on these protocol >>> specific fields? >>> If so, are you planning to extend tc flower OR use other interfaces? >> >> Some of these are already supported through tc on DMFS. >> This patch series adds support for SMFS: Geneve options and MPLS >> both through tc and through rdma-core on root table, >> and GTP-U is supported only through rdma-core on root table. > > What is the interface for rdma-core to hook into the driver to add these > rules? > Is there an equivalent of ndo_setup_tc() that is used with tc interface? This is done through RDMA verbs. Among other things, rdma-core provides an API for a user level application (such as DPDK) to control flow steering through verbs. You can find more details here: https://github.com/linux-rdma/rdma-core Flow steering API is here: https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx5/mlx5dv.h >> -- YK >> >>>> Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com> >>>> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> >>>> --- >>>> � include/linux/mlx5/mlx5_ifc.h | 32 ++++++++++++++++++++++++++++---- >>>> � 1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index f2c51d6833c6..aa6effe1dd6d 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -622,7 +622,19 @@ struct mlx5_ifc_fte_match_set_misc3_bits { u8 geneve_tlv_option_0_data[0x20]; - u8 reserved_at_140[0xc0]; + u8 gtpu_teid[0x20]; + + u8 gtpu_msg_type[0x8]; + u8 gtpu_msg_flags[0x8]; + u8 reserved_at_170[0x10]; + + u8 gtpu_dw_2[0x20]; + + u8 gtpu_first_ext_dw_0[0x20]; + + u8 gtpu_dw_0[0x20]; + + u8 reserved_at_1e0[0x20]; }; struct mlx5_ifc_fte_match_set_misc4_bits { @@ -1237,9 +1249,17 @@ enum { enum { MLX5_FLEX_PARSER_GENEVE_ENABLED = 1 << 3, + MLX5_FLEX_PARSER_MPLS_OVER_GRE_ENABLED = 1 << 4, + mlx5_FLEX_PARSER_MPLS_OVER_UDP_ENABLED = 1 << 5, MLX5_FLEX_PARSER_VXLAN_GPE_ENABLED = 1 << 7, MLX5_FLEX_PARSER_ICMP_V4_ENABLED = 1 << 8, MLX5_FLEX_PARSER_ICMP_V6_ENABLED = 1 << 9, + MLX5_FLEX_PARSER_GENEVE_TLV_OPTION_0_ENABLED = 1 << 10, + MLX5_FLEX_PARSER_GTPU_ENABLED = 1 << 11, + MLX5_FLEX_PARSER_GTPU_DW_2_ENABLED = 1 << 16, + MLX5_FLEX_PARSER_GTPU_FIRST_EXT_DW_0_ENABLED = 1 << 17, + MLX5_FLEX_PARSER_GTPU_DW_0_ENABLED = 1 << 18, + MLX5_FLEX_PARSER_GTPU_TEID_ENABLED = 1 << 19, }; enum { @@ -1637,7 +1657,9 @@ struct mlx5_ifc_cmd_hca_cap_bits { u8 cqe_compression_timeout[0x10]; u8 cqe_compression_max_num[0x10]; - u8 reserved_at_5e0[0x10]; + u8 reserved_at_5e0[0x8]; + u8 flex_parser_id_gtpu_dw_0[0x4]; + u8 reserved_at_5ec[0x4]; u8 tag_matching[0x1]; u8 rndv_offload_rc[0x1]; u8 rndv_offload_dc[0x1]; @@ -1648,7 +1670,8 @@ struct mlx5_ifc_cmd_hca_cap_bits { u8 affiliate_nic_vport_criteria[0x8]; u8 native_port_num[0x8]; u8 num_vhca_ports[0x8]; - u8 reserved_at_618[0x6]; + u8 flex_parser_id_gtpu_teid[0x4]; + u8 reserved_at_61c[0x2]; u8 sw_owner_id[0x1]; u8 reserved_at_61f[0x1]; @@ -1683,7 +1706,8 @@ struct mlx5_ifc_cmd_hca_cap_bits { u8 reserved_at_6e0[0x10]; u8 sf_base_id[0x10]; - u8 reserved_at_700[0x8]; + u8 flex_parser_id_gtpu_dw_2[0x4]; + u8 flex_parser_id_gtpu_first_ext_dw_0[0x4]; u8 num_total_dynamic_vf_msix[0x18]; u8 reserved_at_720[0x14]; u8 dynamic_msix_table_size[0xc];