| Message ID | 613a064fad28ee2afbc14d9a81d4a67b3c1634f7.1605896059.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fix fall-through warnings for Clang | expand |
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:34, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a fallthrough pseudo-keyword. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/atm/fore200e.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c > index 9a70bee84125..ba3ed1b77bc5 100644 > --- a/drivers/atm/fore200e.c > +++ b/drivers/atm/fore200e.c > @@ -423,6 +423,7 @@ fore200e_shutdown(struct fore200e* fore200e) > /* XXX shouldn't we *start* by deregistering the device? */ > atm_dev_deregister(fore200e->atm_dev); > > + fallthrough; > case FORE200E_STATE_BLANK: > /* nothing to do for that state */ > break; >
Hi all, I've added this to my -next[1] branch for v5.14. Thanks -- Gustavo [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp On 4/20/21 15:17, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 11/20/20 12:34, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a fallthrough pseudo-keyword. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/atm/fore200e.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c >> index 9a70bee84125..ba3ed1b77bc5 100644 >> --- a/drivers/atm/fore200e.c >> +++ b/drivers/atm/fore200e.c >> @@ -423,6 +423,7 @@ fore200e_shutdown(struct fore200e* fore200e) >> /* XXX shouldn't we *start* by deregistering the device? */ >> atm_dev_deregister(fore200e->atm_dev); >> >> + fallthrough; >> case FORE200E_STATE_BLANK: >> /* nothing to do for that state */ >> break; >>
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index 9a70bee84125..ba3ed1b77bc5 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -423,6 +423,7 @@ fore200e_shutdown(struct fore200e* fore200e) /* XXX shouldn't we *start* by deregistering the device? */ atm_dev_deregister(fore200e->atm_dev); + fallthrough; case FORE200E_STATE_BLANK: /* nothing to do for that state */ break;
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a fallthrough pseudo-keyword. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/atm/fore200e.c | 1 + 1 file changed, 1 insertion(+)