| Message ID | 20210305090717.GA139387@embeddedor (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,next] sctp: Fix fall-through warnings for Clang | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: clang-built-linux@googlegroups.com ndesaulniers@google.com nathan@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:07, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement and replacing a > comment with a goto statement instead of letting the code fall through > to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > net/sctp/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/input.c b/net/sctp/input.c > index d508f6f3dd08..5ceaf75105ba 100644 > --- a/net/sctp/input.c > +++ b/net/sctp/input.c > @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info) > break; > case ICMP_REDIRECT: > sctp_icmp_redirect(sk, transport, skb); > - /* Fall through to out_unlock. */ > + goto out_unlock; > default: > goto out_unlock; > } > @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net, > net, ch, laddr, > sctp_hdr(skb)->source, > transportp); > + break; > default: > break; > } >
On Tue, Apr 20, 2021 at 03:09:24PM -0500, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? It would go via net/net-next tree, but I can't find this one on patchwork. Just the previous version. http://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&state=*&q=sctp%3A+Fix+fall-through+warnings+for+Clang&archive=both&delegate= I can, however, find it in the archives. https://lore.kernel.org/netdev/20210305090717.GA139387%40embeddedor/T/ Dave and Jakub will know better. Marcelo
Thanks, Marcelo. I'm taking this in my -next[1] branch for v5.14. Thanks -- Gustavo [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp On 4/20/21 15:19, Marcelo Ricardo Leitner wrote: > On Tue, Apr 20, 2021 at 03:09:24PM -0500, Gustavo A. R. Silva wrote: >> Hi all, >> >> Friendly ping: who can take this, please? > > It would go via net/net-next tree, but I can't find this one on > patchwork. Just the previous version. > > http://patchwork.ozlabs.org/project/netdev/list/?series=&submitter=&state=*&q=sctp%3A+Fix+fall-through+warnings+for+Clang&archive=both&delegate= > > I can, however, find it in the archives. > > https://lore.kernel.org/netdev/20210305090717.GA139387%40embeddedor/T/ > > Dave and Jakub will know better. > > Marcelo >
diff --git a/net/sctp/input.c b/net/sctp/input.c index d508f6f3dd08..5ceaf75105ba 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -633,7 +633,7 @@ int sctp_v4_err(struct sk_buff *skb, __u32 info) break; case ICMP_REDIRECT: sctp_icmp_redirect(sk, transport, skb); - /* Fall through to out_unlock. */ + goto out_unlock; default: goto out_unlock; } @@ -1236,6 +1236,7 @@ static struct sctp_association *__sctp_rcv_walk_lookup(struct net *net, net, ch, laddr, sctp_hdr(skb)->source, transportp); + break; default: break; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a break statement and replacing a comment with a goto statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- net/sctp/input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)