| Message ID | 20210423015234.23870-1-maoxiaochuan@loongson.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe3083770c8d98e3dd8b9c6972153528970c251c |
| Headers | show |
| Series | MIPS:DTS:Fix label name and interrupt number of ohci for Loongson-2K | expand |
On 04/23/2021 09:52 AM, xiaochuan mao wrote: > from Loongson-2K1000 user manual know that under pci bus > the device num is 4, function number is 2 and register is 0x2200 > is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has > 64 interrupt sources, 0-31 correspond to the device tree liointc0 device > node, and the other correspond to liointc1 node. so it should be > number 19 correspon to liointc1. > > Signed-off-by: xiaochuan mao <maoxiaochuan@loongson.cn> > Hi, xiaozhuan Thanks for the patch, this is my mistake. Can you correct the GPL-3.0 of this file to GPL-2.0 by the way? Thanks -Qing
On Fri, Apr 23, 2021, at 10:47 AM, maoxiaochuan wrote: > Ok, I will send a another patch for it. Please correct your email client setup. https://www.kernel.org/doc/html/latest/process/email-clients.html > > 祝好 > > > > ------------------ 原始邮件 ------------------ > *发件人:* "zhangqing"<zhangqing@loongson.cn>; > *发送时间:* 2021年4月23日(星期五) 上午10:37 > *收件人:* "xiaochuan mao"<maoxiaochuan@loongson.cn>; "Rob > Herring"<robh+dt@kernel.org>; "Thomas > Bogendoerfer"<tsbogend@alpha.franken.de>; "Jiaxun > Yang"<jiaxun.yang@flygoat.com>; > *抄送:* "devicetree"<devicetree@vger.kernel.org>; > "linux-mips"<linux-mips@vger.kernel.org>; > "linux-kernel"<linux-kernel@vger.kernel.org>; > *主题:* Re: [PATCH] MIPS:DTS:Fix label name and interrupt number of ohci > for Loongson-2K > > > On 04/23/2021 09:52 AM, xiaochuan mao wrote: > > from Loongson-2K1000 user manual know that under pci bus > > the device num is 4, function number is 2 and register is 0x2200 > > is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has > > 64 interrupt sources, 0-31 correspond to the device tree liointc0 device > > node, and the other correspond to liointc1 node. so it should be > > number 19 correspon to liointc1. > > > > Signed-off-by: xiaochuan mao <maoxiaochuan@loongson.cn> > > > Hi, xiaozhuan > > > Thanks for the patch, this is my mistake. > > Can you correct the GPL-3.0 of this file to GPL-2.0 by the way? > > Thanks > > -Qing
On 2021/4/23 下午12:02, Jiaxun Yang wrote: > > On Fri, Apr 23, 2021, at 10:47 AM, maoxiaochuan wrote: >> Ok, I will send a another patch for it. > Please correct your email client setup. > > > https://www.kernel.org/doc/html/latest/process/email-clients.html thanks for your suggest. >> >> 祝好 >> >> >> >> ------------------ 原始邮件 ------------------ >> *发件人:* "zhangqing"<zhangqing@loongson.cn>; >> *发送时间:* 2021年4月23日(星期五) 上午10:37 >> *收件人:* "xiaochuan mao"<maoxiaochuan@loongson.cn>; "Rob >> Herring"<robh+dt@kernel.org>; "Thomas >> Bogendoerfer"<tsbogend@alpha.franken.de>; "Jiaxun >> Yang"<jiaxun.yang@flygoat.com>; >> *抄送:* "devicetree"<devicetree@vger.kernel.org>; >> "linux-mips"<linux-mips@vger.kernel.org>; >> "linux-kernel"<linux-kernel@vger.kernel.org>; >> *主题:* Re: [PATCH] MIPS:DTS:Fix label name and interrupt number of ohci >> for Loongson-2K >> >> >> On 04/23/2021 09:52 AM, xiaochuan mao wrote: >>> from Loongson-2K1000 user manual know that under pci bus >>> the device num is 4, function number is 2 and register is 0x2200 >>> is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has >>> 64 interrupt sources, 0-31 correspond to the device tree liointc0 device >>> node, and the other correspond to liointc1 node. so it should be >>> number 19 correspon to liointc1. >>> >>> Signed-off-by: xiaochuan mao <maoxiaochuan@loongson.cn> >>> >> Hi, xiaozhuan >> >> >> Thanks for the patch, this is my mistake. >> >> Can you correct the GPL-3.0 of this file to GPL-2.0 by the way? >> >> Thanks >> >> -Qing >
On Fri, Apr 23, 2021 at 09:52:34AM +0800, xiaochuan mao wrote: > from Loongson-2K1000 user manual know that under pci bus > the device num is 4, function number is 2 and register is 0x2200 > is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has > 64 interrupt sources, 0-31 correspond to the device tree liointc0 device > node, and the other correspond to liointc1 node. so it should be > number 19 correspon to liointc1. > > Signed-off-by: xiaochuan mao <maoxiaochuan@loongson.cn> > --- > arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied to mips-next. Thomas.
diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi index fd0e99bfe57b..89f079097f32 100644 --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi @@ -125,14 +125,14 @@ interrupt-parent = <&liointc1>; }; - ehci@4,2 { + ohci@4,2 { compatible = "pci0014,7a24.0", "pci0014,7a24", "pciclass0c0310", "pciclass0c03"; reg = <0x2200 0x0 0x0 0x0 0x0>; - interrupts = <17 IRQ_TYPE_LEVEL_LOW>; + interrupts = <19 IRQ_TYPE_LEVEL_LOW>; interrupt-parent = <&liointc1>; };
from Loongson-2K1000 user manual know that under pci bus the device num is 4, function number is 2 and register is 0x2200 is ohci. the ohci interrupt number is 51. because Loongson-2K1000 has 64 interrupt sources, 0-31 correspond to the device tree liointc0 device node, and the other correspond to liointc1 node. so it should be number 19 correspon to liointc1. Signed-off-by: xiaochuan mao <maoxiaochuan@loongson.cn> --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)